Skip to content

add headers to sub cntl.#2943

Merged
chenBright merged 2 commits intoapache:masterfrom
beesflower:master
Apr 8, 2025
Merged

add headers to sub cntl.#2943
chenBright merged 2 commits intoapache:masterfrom
beesflower:master

Conversation

@beesflower
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Fixed the issue that when using SelectiveChannel, the header could not be transparently transmitted to the subchannel.
Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Copy Markdown
Contributor

wwbmmm commented Apr 8, 2025

LGTM

Comment thread src/brpc/selective_channel.cpp Outdated
Copy link
Copy Markdown
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit c7ed9f6 into apache:master Apr 8, 2025
21 checks passed
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request May 19, 2025
* add headers to sub cntl.

* Simplify header copy

---------

Co-authored-by: beeflowers <luckypan@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants