baidu_std support checksum#2967
Merged
wwbmmm merged 1 commit intoapache:masterfrom Jun 20, 2025
Merged
Conversation
yanglimingcn
force-pushed
the
feature/support_checksum
branch
3 times, most recently
from
e5d953e to
e5793e4
Compare
Contributor
Author
这个PR中协议的checksum_value字段目前定义为uint32，可能后续扩展性不太好，大家有什么建议。
|
Contributor
Author
|
@wwbmmm @chenBright 辛苦看看，给点建议。 |
Contributor
maybe define checksum_value as bytes in proto, as std::string in code? |
yanglimingcn
force-pushed
the
feature/support_checksum
branch
from
e5793e4 to
3b3196b
Compare
Contributor
Author
done |
yanglimingcn
force-pushed
the
feature/support_checksum
branch
from
3b3196b to
d80ce4f
Compare
Contributor
|
LGTM |
yanglimingcn
force-pushed
the
feature/support_checksum
branch
from
d80ce4f to
120d549
Compare
chenBright
reviewed
May 30, 2025
yanglimingcn
force-pushed
the
feature/support_checksum
branch
from
120d549 to
f91cc2b
Compare
chenBright
reviewed
Jun 6, 2025
yanglimingcn
force-pushed
the
feature/support_checksum
branch
from
f91cc2b to
c541f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2159
Problem Summary:
Implementing Checksum Functionality at the bRPC Level:
General Requirement: Similar to the compression feature, implement a unified solution at the bRPC level.
Better Performance: Implementing checksum at the user level requires users to serialize protobuf or other data packets and then calculate the checksum. Implementing it at the bRPC level allows direct use of the serialized results for checksum calculation.
Better Compatibility: Implementing checksum at the user level means users work with protobuf data packets. If the protocol changes and the client and server protocols become inconsistent, checksum calculations based on protobuf will fail, preventing users from leveraging protobuf's compatibility features.
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: