Opt log function name#3017
Merged
chenBright merged 1 commit intoapache:masterfrom Jul 7, 2025
Merged
Conversation
Contributor
|
LGTM |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the log_func_name gflag and always includes function names in log messages by default.
- Updated
LogSinkto forward the overload without using the deprecatedfuncparameter. - Deprecated the
log_func_nameflag and simplifiedFlushWithoutResetto always pass_func.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/butil/logging.h | Removed use of the func parameter in the second OnLogMessage overload. |
| src/butil/logging.cc | Marked log_func_name flag deprecated and always call the overload including function name. |
Comments suppressed due to low confidence (2)
src/butil/logging.cc:155
- [nitpick] Consider adding a space after "[DEPRECATED]" in the flag help text for readability (e.g., "[DEPRECATED] Log function name...").
DEFINE_bool(log_func_name, false, "[DEPRECATED]Log function name in each log. "
src/butil/logging.cc:1387
- Add or update tests to verify that function names are always logged by default and that toggling the deprecated flag has no effect.
bool result = (*ptr)->OnLogMessage(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed: No need for gflag, just implement the function version of OnLogMessage to print the function name.
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: