Skip to content

Opt log function name#3017

Merged
chenBright merged 1 commit intoapache:masterfrom
chenBright:opt_log_func
Jul 7, 2025
Merged

Opt log function name#3017
chenBright merged 1 commit intoapache:masterfrom
chenBright:opt_log_func

Conversation

@chenBright
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed: No need for gflag, just implement the function version of OnLogMessage to print the function name.

Side effects:

  • Performance effects:

  • Breaking backward compatibility:


Check List:

@wwbmmm
Copy link
Copy Markdown
Contributor

wwbmmm commented Jul 7, 2025

LGTM

@chenBright chenBright requested a review from Copilot July 7, 2025 14:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the log_func_name gflag and always includes function names in log messages by default.

  • Updated LogSink to forward the overload without using the deprecated func parameter.
  • Deprecated the log_func_name flag and simplified FlushWithoutReset to always pass _func.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/butil/logging.h Removed use of the func parameter in the second OnLogMessage overload.
src/butil/logging.cc Marked log_func_name flag deprecated and always call the overload including function name.
Comments suppressed due to low confidence (2)

src/butil/logging.cc:155

  • [nitpick] Consider adding a space after "[DEPRECATED]" in the flag help text for readability (e.g., "[DEPRECATED] Log function name...").
DEFINE_bool(log_func_name, false, "[DEPRECATED]Log function name in each log. "

src/butil/logging.cc:1387

  • Add or update tests to verify that function names are always logged by default and that toggling the deprecated flag has no effect.
            bool result = (*ptr)->OnLogMessage(

Comment thread src/butil/logging.cc
@chenBright chenBright merged commit e0fe40e into apache:master Jul 7, 2025
15 checks passed
@chenBright chenBright deleted the opt_log_func branch July 7, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants