Skip to content

Bugfix: SignalTrace mode has memory access problem#3032

Merged
chenBright merged 1 commit intoapache:masterfrom
CodeZHXS:signal_trace_fix
Jul 23, 2025
Merged

Bugfix: SignalTrace mode has memory access problem#3032
chenBright merged 1 commit intoapache:masterfrom
CodeZHXS:signal_trace_fix

Conversation

@CodeZHXS
Copy link
Copy Markdown
Contributor

@CodeZHXS CodeZHXS commented Jul 19, 2025

What problem does this PR solve?

Issue Number: Fix #3031

Problem Summary: SignalTrace mode has memory access problem

What is changed and the side effects?

Changed: use Result instead of Result *

Side effects:

  • Performance effects:

  • Breaking backward compatibility:


Check List:

@CodeZHXS CodeZHXS changed the title Bugfix: SignalTrace mode has memory access problem (#3031) Bugfix: SignalTrace mode has memory access problem Jul 19, 2025
Comment thread src/bthread/task_tracer.cpp Outdated
Comment thread src/bthread/task_tracer.h Outdated
Comment thread src/bthread/task_tracer.cpp Outdated
@chenBright chenBright self-requested a review July 19, 2025 06:34
* Bugfix: SignalTrace mode has memory access problem
Copy link
Copy Markdown
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit 323f033 into apache:master Jul 23, 2025
15 checks passed
@CodeZHXS CodeZHXS deleted the signal_trace_fix branch July 24, 2025 03:59
@CodeZHXS CodeZHXS restored the signal_trace_fix branch July 24, 2025 03:59
wwbmmm pushed a commit that referenced this pull request Aug 2, 2025
* Bugfix: SignalTrace mode has memory access problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signal Trace has memory access problem

2 participants