Add redis allocation size limit#3035
Merged
chenBright merged 3 commits intoapache:masterfrom Jul 22, 2025
Merged
Conversation
chenBright
reviewed
Jul 22, 2025
| if (count > (int64_t)std::numeric_limits<uint32_t>::max()) { | ||
| LOG(ERROR) << "Too many sub replies! max count=2^32-1," | ||
| " actually=" << count; | ||
| int64_t array_size = sizeof(RedisReply) * count; |
Contributor
There was a problem hiding this comment.
Use array_size instead of sizeof(RedisReply) * count in line 243.
Contributor
There was a problem hiding this comment.
array_size should better be modified with "const"
Comment on lines
+411
to
+412
| << (FLAGS_redis_max_allocation_size / sizeof(butil::StringPiece)) | ||
| << ", actually=" << value; |
| " actually=" << len; | ||
| if (len > FLAGS_redis_max_allocation_size) { | ||
| LOG(ERROR) << "command string exceeds max allocation size! max=" | ||
| << FLAGS_redis_max_allocation_size << ", actually=" << len; |
| " actually=" << len; | ||
| if (len > FLAGS_redis_max_allocation_size) { | ||
| LOG(ERROR) << "bulk string exceeds max allocation size! max=" | ||
| << FLAGS_redis_max_allocation_size << ", actually=" << len; |
| int64_t array_size = sizeof(RedisReply) * count; | ||
| if (array_size > FLAGS_redis_max_allocation_size) { | ||
| LOG(ERROR) << "array allocation exceeds max allocation size! max=" | ||
| << FLAGS_redis_max_allocation_size << ", actually=" << array_size; |
wwbmmm
added a commit
to wwbmmm/incubator-brpc
that referenced
this pull request
Jul 31, 2025
This reverts commit d0f8f8f.
wwbmmm
added a commit
that referenced
this pull request
Aug 2, 2025
wwbmmm
added a commit
that referenced
this pull request
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: null
Problem Summary: redis request or response may have a too large size that cause the server to consume too much memory.
What is changed and the side effects?
Changed: Add a limit for allocation size
Side effects:
Performance effects: no
Breaking backward compatibility: Some redis request/response may fail to parse if the data size exceed the default value of redis_max_allocation_size (64M). User can adjust the flag redis_max_allocation_size for their senarios.
Check List: