bthread: fix simd memory align issue#3092
Merged
chenBright merged 1 commit intoapache:masterfrom Sep 15, 2025
Merged
Conversation
chenBright
reviewed
Sep 15, 2025
Contributor
chenBright
left a comment
There was a problem hiding this comment.
Value加上BAIDU_CACHELINE_ALIGNMENT,按64字节对齐能解决问题吗?
Contributor
Author
|
没有看到 |
128c77a to
f02d646
Compare
Contributor
Line 75 in 0e7c644 |
Contributor
struct BAIDU_CACHELINE_ALIGNMENT Value {
int64_t v1;
int64_t v2;
};这样能解决问题吗? |
f02d646 to
239508c
Compare
Contributor
|
Macos ci problems haven been fixed in #3093. Please update and rebase master. |
Contributor
Author
可以的 |
239508c to
640dc75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Fix #3091
Problem Summary: 对入参使用
BAIDU_CACHELINE_ALIGNMENT进行修饰,确保内存对齐What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: