Only store failed SignalSyncs#3128
Merged
chenBright merged 1 commit intoapache:masterfrom Oct 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes memory usage in the task tracer by only storing failed SignalSync objects instead of all SignalSync objects. Previously, successful SignalSyncs were temporarily added to _inuse_signal_syncs and then removed, which was unnecessary overhead.
- Removes the unconditional addition of SignalSync to
_inuse_signal_syncsbefore the polling operation - Adds SignalSync to
_inuse_signal_syncsonly when polling fails (EINTR errno case) - Removes the pop operation for successful SignalSyncs since they're no longer added
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
_inuse_signal_syncs does not need to save successful SignalSyncs, only save failed SignalSyncs.
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: