Skip to content

fix: avoid SIGSEGV in read_proc_status during static initialization #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenBright merged 1 commit into from
Apr 26, 2026
+8 −2
Merged

fix: avoid SIGSEGV in read_proc_status during static initialization #3282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/bvar/default_variables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,12 @@ static bool read_proc_status(ProcStat &stat) {
// see http://man7.org/linux/man-pages/man5/proc.5.html
butil::ScopedFILE fp("/proc/self/stat", "r");
if (NULL == fp) {
PLOG_ONCE(WARNING) << "Fail to open /proc/self/stat";
static bool ever_printed_stat_err = false;
if (!ever_printed_stat_err) {
fprintf(stderr, "WARNING: Fail to open /proc/self/stat, errno=%d. "
"Process status related bvars will be unavailable.\n", errno);
ever_printed_stat_err = true;
Comment on lines +84 to +88
}
return false;
}
if (fscanf(fp, "%d %*s %c "
Expand All @@ -94,7 +99,8 @@ static bool read_proc_status(ProcStat &stat) {
&stat.flags, &stat.minflt, &stat.cminflt, &stat.majflt,
&stat.cmajflt, &stat.utime, &stat.stime, &stat.cutime, &stat.cstime,
&stat.priority, &stat.nice, &stat.num_threads) != 19) {
PLOG(WARNING) << "Fail to fscanf";
fprintf(stderr, "WARNING: Fail to fscanf /proc/self/stat, errno=%d. "
"Process status related bvars will be unavailable.\n", errno);
return false;
Comment on lines 101 to 104
}
return true;
Expand Down
Loading