perf: add indexed dict lookups to data_svc.locate() for O(1) access by id#3323
Open
deacon-mp wants to merge 1 commit into
Open
perf: add indexed dict lookups to data_svc.locate() for O(1) access by id#3323deacon-mp wants to merge 1 commit into
deacon-mp wants to merge 1 commit into
Conversation
Use in-memory index for O(1) lookups on common fields like paw, ability_id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data_svc.locate() scans full RAM list for each lookup. Added id-indexed dicts for O(1) lookups. With tests.