Skip to content

fix(trait): report builder task strategy errors#6641

Merged
squakez merged 1 commit into
apache:mainfrom
thedavidweng:fix/6637-builder-task-error-message
May 20, 2026
Merged

fix(trait): report builder task strategy errors#6641
squakez merged 1 commit into
apache:mainfrom
thedavidweng:fix/6637-builder-task-error-message

Conversation

@thedavidweng
Copy link
Copy Markdown
Contributor

@thedavidweng thedavidweng commented May 20, 2026

Fixes #6637

Running an Integration with builder.tasks and a non-pod build strategy moves the related IntegrationKit to Error, but the Integration only reports the generic kit error state.

The builder trait already sets a specific IntegrationKitTasksValid condition. However, the Integration status uses IntegrationKit.Status.Failure when appending the detailed failure reason, and this path was not populated for this builder trait failure.

Description

  • Set IntegrationKit.Status.Failure when the builder trait reports a fatal IntegrationKit configuration error.
  • Cover the builder.tasks plus routine build strategy path with unit assertions.
  • Verify the Integration build-kit action includes the propagated failure reason in the Integration condition.

Release Note

fix(trait): Report builder task strategy errors on Integration status

@github-actions
Copy link
Copy Markdown
Contributor

✔️ Unit test coverage report - coverage increased from 62.8% to 62.9% (+0.1%)

Copy link
Copy Markdown
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thanks for the contribution!

@squakez squakez merged commit 2ae4884 into apache:main May 20, 2026
14 of 15 checks passed
@thedavidweng thedavidweng deleted the fix/6637-builder-task-error-message branch May 20, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running an Integration with builder.tasks but not strategy pod does not return proper error message

2 participants