CAMEL-23239: Fix review issues in camel-state-store

- Fix Infinispan backend lifecycle: nullify cache in stop() to allow restart
- Fix InMemory putIfAbsent race condition: use compute() for atomicity
- Fix Caffeine put()/delete() atomicity: use asMap() for atomic previous-value return
- Fix Redis stop(): nullify mapCache for lifecycle hygiene
- Increase TTL test sleep margins to 5x to prevent CI flakiness
- Document first-one-wins semantics on getOrCreateBackend()

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

components/camel-state-store/camel-state-store-caffeine/src/main/java/org/apache/camel/component/statestore/caffeine/CaffeineStateStoreBackend.java

@@ -35,8 +35,7 @@ public class CaffeineStateStoreBackend implements StateStoreBackend {
 
     @Override
     public Object put(String key, Object value, long ttlMillis) {
-        TimedValue previous = cache.getIfPresent(key);
-        cache.put(key, new TimedValue(value, ttlMillis));
+        TimedValue previous = cache.asMap().put(key, new TimedValue(value, ttlMillis));
         return previous != null ? previous.value() : null;
     }
 
@@ -48,8 +47,7 @@ public Object get(String key) {
 
     @Override
     public Object delete(String key) {
-        TimedValue previous = cache.getIfPresent(key);
-        cache.invalidate(key);
+        TimedValue previous = cache.asMap().remove(key);
         return previous != null ? previous.value() : null;
     }
 

components/camel-state-store/camel-state-store-caffeine/src/test/java/org/apache/camel/component/statestore/caffeine/CaffeineStateStoreBackendTest.java

@@ -151,7 +151,7 @@ void testTtlExpiry() throws Exception {
                 Map.of(StateStoreConstants.KEY, "ttlKey"));
         assertEquals("expiring", result);
 
-        Thread.sleep(400);
+        Thread.sleep(1000);
         backend.keys(); // trigger Caffeine cleanup
 
         result = template.requestBodyAndHeaders(
@@ -172,7 +172,7 @@ void testPerMessageTtlHeader() throws Exception {
                 Map.of(StateStoreConstants.KEY, "ttlKey"));
         assertEquals("expiring", result);
 
-        Thread.sleep(400);
+        Thread.sleep(1000);
         backend.keys();
 
         result = template.requestBodyAndHeaders(

components/camel-state-store/camel-state-store-infinispan/src/main/java/org/apache/camel/component/statestore/infinispan/InfinispanStateStoreBackend.java

@@ -120,6 +120,7 @@ public void start() {
 
     @Override
     public void stop() {
+        cache = null;
         if (managedCacheManager && cacheManager != null) {
             cacheManager.stop();
             cacheManager = null;

components/camel-state-store/camel-state-store-infinispan/src/test/java/org/apache/camel/component/statestore/infinispan/InfinispanStateStoreBackendIT.java

@@ -176,7 +176,7 @@ void testTtlExpiry() throws Exception {
                 Map.of(StateStoreConstants.KEY, "ttlKey"));
         assertEquals("expiring", result);
 
-        Thread.sleep(700);
+        Thread.sleep(2500);
 
         result = template.requestBodyAndHeaders(
                 "direct:get", null,

components/camel-state-store/camel-state-store-redis/src/main/java/org/apache/camel/component/statestore/redis/RedisStateStoreBackend.java

@@ -96,6 +96,7 @@ public void start() {
 
     @Override
     public void stop() {
+        mapCache = null;
         if (managedRedisson && redisson != null) {
             redisson.shutdown();
             redisson = null;

components/camel-state-store/camel-state-store-redis/src/test/java/org/apache/camel/component/statestore/redis/RedisStateStoreBackendIT.java

@@ -166,7 +166,7 @@ void testTtlExpiry() throws Exception {
                 Map.of(StateStoreConstants.KEY, "ttlKey"));
         assertEquals("expiring", result);
 
-        Thread.sleep(700);
+        Thread.sleep(2500);
 
         result = template.requestBodyAndHeaders(
                 "direct:get", null,

components/camel-state-store/camel-state-store/src/main/java/org/apache/camel/component/statestore/InMemoryStateStoreBackend.java

@@ -76,16 +76,15 @@ public boolean contains(String key) {
     @Override
     public Object putIfAbsent(String key, Object value, long ttlMillis) {
         long expiresAt = ttlMillis > 0 ? System.currentTimeMillis() + ttlMillis : 0;
-        Entry existing = store.putIfAbsent(key, new Entry(value, expiresAt));
-        if (existing != null) {
-            if (existing.isExpired()) {
-                // expired, replace it
-                store.replace(key, existing, new Entry(value, expiresAt));
-                return null;
+        Object[] result = new Object[1];
+        store.compute(key, (k, current) -> {
+            if (current == null || current.isExpired()) {
+                return new Entry(value, expiresAt);
             }
-            return existing.value();
-        }
-        return null;
+            result[0] = current.value();
+            return current;
+        });
+        return result[0];
     }
 
     @Override

components/camel-state-store/camel-state-store/src/main/java/org/apache/camel/component/statestore/StateStoreComponent.java

@@ -43,6 +43,11 @@ protected Endpoint createEndpoint(String uri, String remaining, Map<String, Obje
         return endpoint;
     }
 
+    /**
+     * Returns the backend for the given store name, creating one if needed. Uses first-one-wins semantics: if a backend
+     * already exists for this store name, subsequent calls return the existing one regardless of the explicit backend
+     * passed.
+     */
     StateStoreBackend getOrCreateBackend(String storeName, StateStoreBackend explicitBackend) {
         if (explicitBackend != null) {
             return backends.computeIfAbsent(storeName, k -> {

components/camel-state-store/camel-state-store/src/test/java/org/apache/camel/component/statestore/StateStoreTest.java

@@ -191,7 +191,7 @@ void testPerMessageTtlHeader() throws Exception {
                 Map.of(StateStoreConstants.KEY, "ttlKey"));
         assertEquals("expiring", result);
 
-        Thread.sleep(300);
+        Thread.sleep(1000);
 
         // should be expired
         result = template.requestBodyAndHeaders(

components/camel-state-store/camel-state-store/src/test/java/org/apache/camel/component/statestore/StateStoreTtlTest.java

@@ -38,8 +38,8 @@ void testEntryExpiresAfterTtl() throws Exception {
                 java.util.Map.of(StateStoreConstants.KEY, "ttlKey"));
         assertEquals("expiring", result);
 
-        // wait for TTL to expire
-        Thread.sleep(300);
+        // wait for TTL to expire (5x margin over 200ms TTL)
+        Thread.sleep(1000);
 
         // should be expired now
         Object expired = template.requestBodyAndHeaders(
@@ -54,7 +54,7 @@ void testContainsReturnsFalseAfterTtl() throws Exception {
                 "direct:put", "expiring",
                 java.util.Map.of(StateStoreConstants.KEY, "ttlKey"));
 
-        Thread.sleep(300);
+        Thread.sleep(1000);
 
         Object exists = template.requestBodyAndHeaders(
                 "direct:contains", null,