You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: AGENTS.md
+109Lines changed: 109 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -43,6 +43,26 @@ These rules apply to ALL AI agents working on this codebase.
43
43
Note: `fixVersions` cannot be set on an already-closed issue — set it before closing,
44
44
or reopen/set/close if needed.
45
45
46
+
### PR Description Maintenance
47
+
48
+
When pushing new commits to a PR, **always update the PR description** (and title if needed) to
49
+
reflect the current state of the changeset. PRs evolve across commits — the description must stay
50
+
accurate and complete. Use `gh pr edit --title "..." --body "..."` after each push.
51
+
52
+
### PR Reviewers
53
+
54
+
When creating a PR, **always identify and request reviews** from the most relevant committers:
55
+
56
+
- Run `git log --format='%an' --since='1 year' -- <affected-files> | sort | uniq -c | sort -rn | head -10`
57
+
to find who has been most active on the affected files.
58
+
- Use `git blame` on key modified files to identify who wrote the code being changed.
59
+
- Cross-reference with the [committer list](https://camel.apache.org/community/team/#committers)
60
+
to ensure you request reviews from active committers (not just contributors).
61
+
- For component-specific changes, prefer reviewers who have recently worked on that component.
62
+
- For cross-cutting changes (core, API), include committers with broader project knowledge.
63
+
- Request review from **at least 2 relevant committers** using `gh pr edit --add-reviewer`.
64
+
- When all comments on the Pull Request are addressed (by providing a fix or providing more explanation) and the PR checks are green, re-request review on existing reviewers so that they are aware that the new changeset is ready to be reviewed.
65
+
46
66
### Merge Requirements
47
67
48
68
- An agent MUST NOT merge a PR if there are any **unresolved review conversations**.
@@ -56,6 +76,95 @@ These rules apply to ALL AI agents working on this codebase.
56
76
- All code must pass formatting checks (`mvn formatter:format impsort:sort`) before pushing.
57
77
- All generated files must be regenerated and committed (CI checks for uncommitted changes).
58
78
79
+
### Asynchronous Testing: Use Awaitility Instead of Thread.sleep
80
+
81
+
Do **NOT** use `Thread.sleep()` in test code. It leads to flaky, slow, and non-deterministic tests.
82
+
Use the [Awaitility](https://github.com/awaitility/awaitility) library instead, which is already
83
+
available as a test dependency in the project.
84
+
85
+
**Example — waiting for a route to be registered:**
0 commit comments