Fix flaky HazelcastReplicatedmapConsumerTest (18% failure rate)

[gnodet]

Summary

Claude Code on behalf of gnodet

Fixes the persistent flakiness of HazelcastReplicatedmapConsumerTest (18% failure rate on Develocity — 35/194 runs failing). The prior fix (CAMEL-22506) added map.clear() + mock reset in @BeforeEach, but that approach itself introduces the flakiness because clear() fires async REMOVED events through the still-active Hazelcast entry listener.

Root cause: map.clear() in @BeforeEach fires async REMOVED events that bleed between tests because the Hazelcast EntryListener is still registered. Additionally, testRemove() calls map.remove() immediately after map.put() without waiting for the ADDED event to be processed, creating a race condition.

Fix:

• @BeforeEach: Stop routes before clearing the map to deregister the entry listener (via HazelcastReplicatedmapConsumer.doStop()), preventing stale REMOVED events from reaching mock endpoints. Restart routes after clearing and resetting mocks.
• testRemove(): Wait for the ADDED event to be delivered before calling remove(), eliminating the put/remove race.
• testEvict(): Replace redundant Awaitility-wrapped MockEndpoint.assertIsSatisfied() with the native latch-based timed assertion (per project conventions — Awaitility polls on top of an already-waiting mechanism).

Test plan

• All 3 tests pass locally
• Validated with 100 consecutive runs — 0 failures (vs. ~18 expected failures without fix)
• Code formatted with mvn formatter:format impsort:sort
• CI build passed (Java 17 ✅, Java 25 ✅) — run 29100025144

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run
• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
• You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
• Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[gnodet]

Clean fix for the flaky test. The root cause analysis is correct — async REMOVED events from map.clear() in resetState() were bleeding into the next test's mock expectations.

All three changes look good:

1. Route stop/start around map.clear() — deregisters the Hazelcast entry listener so clear() doesn't fire events into the mock
2. testEvict() — correctly replaced Awaitility.await().untilAsserted(() -> MockEndpoint.assertIsSatisfied(...)) with the native MockEndpoint.assertIsSatisfied(context, 30000, TimeUnit.MILLISECONDS) — avoids polling-on-top-of-latch per project conventions
3. testRemove() — Awaitility wait for ADDED event counter before removing is the right pattern (mid-test condition that MockEndpoint can't express natively)

LGTM.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet

[github-actions]

🧪 CI tested the following changed modules:

• components/camel-hazelcast

---

🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 9 all tested

Maveniverse Scalpel detected 1 affected modules (current approach: 9).

Modules only in current approach (8)

• camel-jbang-mcp
• camel-jbang-plugin-mcp
• camel-jbang-plugin-route-parser
• camel-jbang-plugin-tui
• camel-jbang-plugin-validate
• camel-launcher-container
• camel-yaml-dsl-validator
• camel-yaml-dsl-validator-maven-plugin

Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules)

Modules Scalpel would test (1)

• camel-hazelcast

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (9 modules)

• Camel :: HazelCast
• Camel :: JBang :: MCP
• Camel :: JBang :: Plugin :: MCP
• Camel :: JBang :: Plugin :: Route Parser
• Camel :: JBang :: Plugin :: TUI
• Camel :: JBang :: Plugin :: Validate
• Camel :: Launcher :: Container
• Camel :: YAML DSL :: Validator
• Camel :: YAML DSL :: Validator Maven Plugin

---

⚙️ View full build and test results