CAMEL-23981: Fix 12 camel-yaml-dsl bugs

[davsclaus]

Summary

Claude Code on behalf of davsclaus

Fixes 12 YAML DSL bugs reported by Federico Mariani (CAMEL-23981 through CAMEL-23992):

• CAMEL-23981: springTransactionErrorHandler was creating JtaTransactionErrorHandlerDefinition instead of SpringTransactionErrorHandlerDefinition
• CAMEL-23982: Bean cache cleared too early when loading multiple YAML files
• CAMEL-23983: @YamlProperty flag emission swapped withRequired/withDeprecated and withIsSecret used wrong accessor
• CAMEL-23984: Unsupported top-level YAML mappings silently ignored without warning
• CAMEL-23985: Pipe handling lacked validation for unsupported ref kinds, missing sink endpoint, and empty errorHandler
• CAMEL-23986: routeConfiguration lost line number, source location, and resource metadata
• CAMEL-23987: Missing note property on from, routeConfiguration, and kamelet deserializers
• CAMEL-23988: MultiValue endpoint parameters not flattened when URI has a path
• CAMEL-23989: nodeAt() matched later pointer segments at wrong depth due to leading / handling
• CAMEL-23990: MessageFormat crash when error messages contain curly braces
• CAMEL-23991: ValidateMojo ignored application.yaml only (not application.properties.yaml) and used static field for per-instance state
• CAMEL-23992: Inverted $ref check in extractRequiredFromComposition

Test plan

• Unit tests added for CAMEL-23981 (springTransactionErrorHandler type), CAMEL-23985 (unsupported ref kind), CAMEL-23986 (line number/location), CAMEL-23987 (note property on from/routeConfiguration/kamelet), CAMEL-23989 (nodeAt 7 tests)
• All 387 tests in camel-yaml-dsl pass (1 pre-existing failure in RestTest tracked by CAMEL-24004)
• All tests in camel-yaml-dsl-common pass
• Regenerated schema and deserializer files committed

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run
• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
• You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
• Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[gnodet]

Claude Code review on behalf of @gnodet

Review: CAMEL-23981 — Fix 12 camel-yaml-dsl bugs

High-quality, well-organized PR fixing 12 genuine bugs across the YAML DSL subsystem. The fixes are correct, well-scoped, and have good test coverage for the non-trivial changes. Generated schema/deserializer files have been properly regenerated.

Summary of All 12 Fixes

#	JIRA	Bug	Has Test?
1	CAMEL-23981	springTransactionErrorHandler created wrong JtaTransactionErrorHandlerDefinition	✅
2	CAMEL-23982	Bean cache cleared too early when loading multiple YAML files	❌ (low risk)
3	CAMEL-23983	@YamlProperty swapped withRequired/withDeprecated, withIsSecret used wrong accessor	Schema regen
4	CAMEL-23984	Unsupported top-level YAML mappings silently ignored	❌ (warning log)
5	CAMEL-23985	Pipe handling lacked validation for unsupported ref kinds, missing sink, empty errorHandler	✅
6	CAMEL-23986	routeConfiguration lost line number, source location, and resource metadata	✅
7	CAMEL-23987	Missing note property on from, routeConfiguration, and kamelet	✅ (3 tests)
8	CAMEL-23988	MultiValue endpoint parameters not flattened when URI has a path	Schema regen
9	CAMEL-23989	nodeAt() matched later pointer segments at wrong depth	✅ (7 tests)
10	CAMEL-23990	MessageFormat crash when error messages contain curly braces	❌ (defensive)
11	CAMEL-23991	ValidateMojo ignored application.yaml only, used static for per-instance state	❌ (straightforward)
12	CAMEL-23992	Inverted $ref check in extractRequiredFromComposition	Schema regen

Finding: Two missed withIsSecret instances (CAMEL-23983)

In GenerateYamlDeserializersMojo.java, two instances of the same bug at approximately lines 912 and 951 (in the java.util.List non-String and java.util.Set non-String parametrized type branches) were missed. Both still read:

.withIsSecret(descriptor.defaultValue(name))

when they should be:

.withIsSecret(descriptor.isSecret(name))

These handle List<SomeObject> and Set<SomeObject> properties — less common but still incorrect. Recommend fixing for completeness since the same pattern is fixed everywhere else in the file.

Other Observations (no action needed)

• extractRequiredFromComposition fix (CAMEL-23992): The original inverted if (!compositionEntry.has("$ref")) was also a latent NPE — it would try compositionEntry.get("$ref").asText() when $ref was absent. Fix is correct.

• ValidateMojo IGNORE_FILE (CAMEL-23991): The old "application.yml" was compared against FileUtil.onlyName() which strips extensions, so "application.yml".equals("application") was always false — the ignore never worked. Fix to "application" is correct. The static → instance field change for yamlFiles is also correct (prevents cross-module contamination in reactor builds).

• MessageFormat fix (CAMEL-23990): Using new MessageFormat(e.getMessage()) would crash on YAML/JSON parse errors containing {/} characters. Fix to new MessageFormat("{0}").arguments(msg) is the correct defensive pattern.

• nodeAt fix (CAMEL-23989): The 7 Spock tests provide excellent coverage of the recursive pointer matching logic.

Overall: Very well done. The two missed withIsSecret instances are the only actionable item.

[davsclaus]

Claude Code on behalf of davsclaus

@gnodet Thanks for the thorough review!

Regarding the two withIsSecret instances at lines 912 and 951 — those are already fixed in the CAMEL-23983 commit. Both lines currently use descriptor.isSecret(name) (not descriptor.defaultValue(name)). All occurrences across the file were corrected.

[github-actions]

🧪 CI tested the following changed modules:

• dsl/camel-yaml-dsl/camel-yaml-dsl-common
• dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers
• dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin
• dsl/camel-yaml-dsl/camel-yaml-dsl-validator-maven-plugin
• dsl/camel-yaml-dsl/camel-yaml-dsl-validator
• dsl/camel-yaml-dsl/camel-yaml-dsl

---

🔬 Scalpel shadow comparison — Scalpel: 12 tested, 10 compile-only — current: 9 all tested

Maveniverse Scalpel detected 22 affected modules (current approach: 9).

⚠️ Modules only in Scalpel (13)

• camel-jbang-core
• camel-jbang-it
• camel-jbang-main
• camel-jbang-plugin-edit
• camel-jbang-plugin-generate
• camel-jbang-plugin-kubernetes
• camel-jbang-plugin-test
• camel-kamelet-main
• camel-launcher
• camel-yaml-dsl
• camel-yaml-dsl-deserializers
• camel-yaml-dsl-maven-plugin
• coverage

Skip-tests mode would test 12 modules (6 direct + 6 downstream), skip tests for 10 (generated code, meta-modules)

Modules Scalpel would test (12)

• camel-jbang-mcp
• camel-jbang-plugin-mcp
• camel-jbang-plugin-route-parser
• camel-jbang-plugin-tui
• camel-jbang-plugin-validate
• camel-launcher-container
• camel-yaml-dsl
• camel-yaml-dsl-common
• camel-yaml-dsl-deserializers
• camel-yaml-dsl-maven-plugin
• camel-yaml-dsl-validator
• camel-yaml-dsl-validator-maven-plugin

Modules with tests skipped (10)

• camel-jbang-core
• camel-jbang-it
• camel-jbang-main
• camel-jbang-plugin-edit
• camel-jbang-plugin-generate
• camel-jbang-plugin-kubernetes
• camel-jbang-plugin-test
• camel-kamelet-main
• camel-launcher
• coverage

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (22 modules)

• Camel :: Coverage
• Camel :: JBang :: Core
• Camel :: JBang :: Integration tests
• Camel :: JBang :: MCP
• Camel :: JBang :: Main
• Camel :: JBang :: Plugin :: Edit
• Camel :: JBang :: Plugin :: Generate
• Camel :: JBang :: Plugin :: Kubernetes
• Camel :: JBang :: Plugin :: MCP
• Camel :: JBang :: Plugin :: Route Parser
• Camel :: JBang :: Plugin :: TUI
• Camel :: JBang :: Plugin :: Testing
• Camel :: JBang :: Plugin :: Validate
• Camel :: Kamelet Main
• Camel :: Launcher
• Camel :: Launcher :: Container
• Camel :: YAML DSL
• Camel :: YAML DSL :: Common
• Camel :: YAML DSL :: Deserializers
• Camel :: YAML DSL :: Maven Plugins
• Camel :: YAML DSL :: Validator
• Camel :: YAML DSL :: Validator Maven Plugin

---

⚙️ View full build and test results