fix(ci): update GitHub Actions and optimize CI configuration with code quality improvements#390
Closed
cici0602 wants to merge 1 commit into
Closed
fix(ci): update GitHub Actions and optimize CI configuration with code quality improvements#390cici0602 wants to merge 1 commit into
cici0602 wants to merge 1 commit into
Conversation
chore: update GitHub Actions to latest versions - Update actions/cache from v1/v2 to v4 in all workflow files - Update actions/checkout to v4 in all workflow files - Update codecov/codecov-action from v1 to v4 ci: optimize configuration and fix several issues Correct macOS runner name to macos-latest Enhance GNU tar installation robustness and set PATH via for Homebrew paths Fix YAML matrix indentation errors Add fallback for cache key suffix (use github.run_id when secrets.CACHE_VERSION is unavailable) Split toolchain installation and conditional components install to avoid beta channel failures Pin smrpn/criterion-compare-action to @v1 in pull_request.yml fix(ci): install clippy on all toolchains to prevent beta build failures Remove conditional installation that only installed clippy on stable toolchain, ensuring clippy checks work consistently across both stable and beta toolchains. Fixes 'cargo-clippy is not installed' error on macOS beta toolchain. fix: address clippy lints (io-other-error, mismatched-lifetime-syntaxes) - use std::io::Error::other(...) instead of io::Error::new(..., ErrorKind::Other) - add explicit lifetime to Cow return type in escape_eval - remove related unused imports fix: resolve io_other_error clippy warnings style: fix code formatting issues for cargo fmt Replace deprecated smrpn action with boa-dev/criterion-compare-action@v3.2.4 Explicitly pass branchName: ${{ github.base_ref }} to ensure correct PR baseline comparison. fix(github-actions): update cache configuration to use v4 and add restore-keys Resolve deprecated actions/cache v2.1.4 error by updating path configuration and adding restore-keys fallback mechanism for better cache compatibility. checkout v4->v5 ci: use pull_request trigger so PR branch workflow (actions/cache@v4) is used criterion-compare-action v1 -> master Added fetch-depth: 0 to checkout action to ensure all branches are available for criterion-compare-action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI and Code Improvements
This PR implements a series of CI workflow improvements and code fixes to enhance build reliability, address deprecation warnings, and maintain code quality.
GitHub Actions Updates
actions/cachefrom v1/v2 to v4 across all workflow files for better caching performanceactions/checkoutto v4/v5 in all workflowscodecov/codecov-actionfrom v1 to v4smrpn/criterion-compare-actionwithboa-dev/criterion-compare-action@v3.2.4and explicitly passedbranchName: ${{ github.base_ref }}for correct PR baseline comparisonsmrpn/criterion-compare-actionto appropriate versionsCI Configuration Optimizations
macos-latestgithub.run_idwhensecrets.CACHE_VERSIONis unavailablefetch-depth: 0to checkout action to ensure all branches are available for benchmark comparisonCode Quality Fixes
std::io::Error::other(...)instead ofio::Error::new(..., ErrorKind::Other)Cowreturn type inescape_evalcargo fmtThese changes improve the overall CI pipeline reliability, address deprecation warnings, and maintain high code quality standards for the project.