Skip to content

feat(watcher): Add notification payload to watcher callback signature#392

Merged
hsluoyz merged 4 commits into
apache:masterfrom
cici0602:feat/watcher-payload
Sep 24, 2025
Merged

feat(watcher): Add notification payload to watcher callback signature#392
hsluoyz merged 4 commits into
apache:masterfrom
cici0602:feat/watcher-payload

Conversation

@cici0602
Copy link
Copy Markdown
Contributor

@cici0602 cici0602 commented Sep 19, 2025

Fix: #375

@github-actions
Copy link
Copy Markdown

Benchmark for ea85a2b

Click to view benchmark
Test PR Benchmark Master Benchmark %
b_benchmark_rbac_model_large 9.6±0.03ms 10.0±0.03ms -4.00%
benchmark priority model 4.0±0.05µs 4.1±0.05µs -2.44%
benchmark_abac_model 2.5±0.03µs 2.5±0.03µs 0.00%
benchmark_basic_model 3.7±0.07µs 3.7±0.04µs 0.00%
benchmark_key_match 6.7±0.10µs 6.8±0.10µs -1.47%
benchmark_raw 0.0±0.00ns 0.0±0.00ns NaN%
benchmark_rbac_model 5.9±0.07µs 6.0±0.07µs -1.67%
benchmark_rbac_model_medium 791.0±7.33µs 846.4±7.86µs -6.55%
benchmark_rbac_model_with_domains 5.7±0.08µs 5.7±0.08µs 0.00%
benchmark_rbac_with_deny 8.1±0.08µs 8.4±0.05µs -3.57%
benchmark_rbac_with_resource_roles 4.3±0.05µs 4.3±0.04µs 0.00%
benchmark_role_manager_large 4.3±0.01ms 4.3±0.01ms 0.00%
benchmark_role_manager_medium 269.4±2.32µs 269.4±3.78µs 0.00%
benchmark_role_manager_small 29.4±0.41µs 30.4±0.45µs -3.29%

@github-actions
Copy link
Copy Markdown

Benchmark for ea85a2b

Click to view benchmark
Test PR Benchmark Master Benchmark %
b_benchmark_rbac_model_large 9.5±0.06ms 9.7±0.06ms -2.06%
benchmark priority model 4.0±0.05µs 4.0±0.05µs 0.00%
benchmark_abac_model 2.5±0.03µs 2.5±0.02µs 0.00%
benchmark_basic_model 3.7±0.06µs 3.6±0.06µs +2.78%
benchmark_key_match 6.8±0.07µs 6.7±0.10µs +1.49%
benchmark_raw 0.0±0.00ns 0.0±0.00ns NaN%
benchmark_rbac_model 5.9±0.08µs 5.9±0.11µs 0.00%
benchmark_rbac_model_medium 791.0±8.02µs 795.3±7.05µs -0.54%
benchmark_rbac_model_with_domains 5.7±0.10µs 5.6±0.07µs +1.79%
benchmark_rbac_with_deny 8.0±0.13µs 8.1±0.10µs -1.23%
benchmark_rbac_with_resource_roles 4.2±0.05µs 4.2±0.06µs 0.00%
benchmark_role_manager_large 4.3±0.02ms 4.3±0.01ms 0.00%
benchmark_role_manager_medium 270.7±3.34µs 268.4±3.88µs +0.86%
benchmark_role_manager_small 29.8±0.39µs 29.8±0.30µs 0.00%

@hsluoyz
Copy link
Copy Markdown
Member

hsluoyz commented Sep 21, 2025

@byrnedo plz review

@byrnedo
Copy link
Copy Markdown

byrnedo commented Sep 21, 2025

@byrnedo plz review

Oh thank you @hsluoyz ill try carve out time next week

@cici0602 cici0602 force-pushed the feat/watcher-payload branch from 8c0ba51 to 542a827 Compare September 23, 2025 11:18
@github-actions
Copy link
Copy Markdown

Benchmark for ea85a2b

Click to view benchmark
Test PR Benchmark Master Benchmark %
b_benchmark_rbac_model_large 9.6±0.05ms 9.6±0.04ms 0.00%
benchmark priority model 4.1±0.04µs 4.1±0.05µs 0.00%
benchmark_abac_model 2.5±0.03µs 2.5±0.06µs 0.00%
benchmark_basic_model 3.7±0.15µs 3.7±0.03µs 0.00%
benchmark_key_match 6.9±0.11µs 6.7±0.09µs +2.99%
benchmark_raw 0.0±0.00ns 0.0±0.00ns NaN%
benchmark_rbac_model 6.0±0.07µs 6.0±0.08µs 0.00%
benchmark_rbac_model_medium 792.9±9.43µs 810.3±9.79µs -2.15%
benchmark_rbac_model_with_domains 5.8±0.06µs 5.8±0.09µs 0.00%
benchmark_rbac_with_deny 8.3±0.14µs 8.2±0.11µs +1.22%
benchmark_rbac_with_resource_roles 4.4±0.10µs 4.3±0.06µs +2.33%
benchmark_role_manager_large 4.3±0.02ms 4.3±0.01ms 0.00%
benchmark_role_manager_medium 268.4±3.15µs 269.6±4.96µs -0.45%
benchmark_role_manager_small 29.0±0.36µs 30.9±0.99µs -6.15%

@hsluoyz hsluoyz merged commit ba57d3b into apache:master Sep 24, 2025
10 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (c5a05d3) to head (542a827).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #392       +/-   ##
=========================================
- Coverage   65.54%      0   -65.55%     
=========================================
  Files          25      0       -25     
  Lines        1956      0     -1956     
=========================================
- Hits         1282      0     -1282     
+ Misses        674      0      -674     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions Bot pushed a commit that referenced this pull request Sep 24, 2025
# [2.13.0](v2.12.0...v2.13.0) (2025-09-24)

### Features

* **watcher:** Add notification payload to watcher callback signature ([#392](#392)) ([ba57d3b](ba57d3b))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cici0602 cici0602 deleted the feat/watcher-payload branch September 26, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shouldn't watcher callback be passed the notification data

3 participants