Add BFSDetector as second default cycle detector#1667
Closed
Copilot wants to merge 5 commits into
Closed
Conversation
|
|
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
…code review feedback Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add second default detector feature
Add BFSDetector as second default cycle detector
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a second default detector implementing Kahn's algorithm (topological sort) for cycle detection in role inheritance graphs, running alongside the existing DFS-based detector.
Implementation
detector/bfs_detector.go: NewBFSDetectorimplementing theDetectorinterface using Kahn's algorithm withcontainer/listfor O(1) queue operationsdetector/bfs_detector_test.go: Comprehensive test suite mirroringDefaultDetectortests (nil checks, simple/complex cycles, self-loops, disconnected components, diamond patterns, performance with 10K nodes)enforcer.go: Initialize with both detectors by default:[]detector.Detector{detector.NewDefaultDetector(), detector.NewBFSDetector()}enforcer_test.go: Integration test verifying both detectors work togetherAlgorithm Difference
Both run on policy load via
RunDetections(). Users can still override withSetDetector()orSetDetectors()if desired.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.