Modified DisableInitialHostLookup flag name and logic

Author: RostislavPorohnya

cluster.go

@@ -189,12 +189,12 @@ type ClusterConfig struct {
 	// set to 10.0.0.1 which is what will be used to connect to.
 	IgnorePeerAddr bool
 
-	// If DisableInitialHostLookup then the driver will not attempt to get host info
+	// If DisableHostLookup then the driver will not attempt to get host info
 	// from the system.peers table, this will mean that the driver will connect to
 	// hosts supplied and will not attempt to lookup the hosts information, this will
 	// mean that data_centre, rack and token information will not be available and as
 	// such host filtering and token aware query routing will not be available.
-	DisableInitialHostLookup bool
+	DisableHostLookup bool
 
 	// Configure events the driver will register for
 	Events struct {

conn.go

@@ -1689,36 +1689,37 @@ func (c *Conn) querySystemLocal(ctx context.Context) *Iter {
 func (c *Conn) awaitSchemaAgreement(ctx context.Context) (err error) {
 	const localSchemas = "SELECT schema_version FROM system.local WHERE key='local'"
 
-	var versions map[string]struct{}
+	versions := make(map[string]struct{})
 	var schemaVersion string
 
 	endDeadline := time.Now().Add(c.session.cfg.MaxWaitSchemaAgreement)
 
 	for time.Now().Before(endDeadline) {
-		iter := c.querySystemPeers(ctx, c.host.version)
+		iter := &Iter{}
+		if !c.session.cfg.DisableHostLookup {
+			iter = c.querySystemPeers(ctx, c.host.version)
 
-		versions = make(map[string]struct{})
-
-		rows, err := iter.SliceMap()
-		if err != nil {
-			goto cont
-		}
-
-		for _, row := range rows {
-			host, err := c.session.hostInfoFromMap(row, &HostInfo{connectAddress: c.host.ConnectAddress(), port: c.session.cfg.Port})
+			rows, err := iter.SliceMap()
 			if err != nil {
 				goto cont
 			}
-			if !isValidPeer(host) || host.schemaVersion == "" {
-				c.logger.Printf("invalid peer or peer with empty schema_version: peer=%q", host)
-				continue
-			}
 
-			versions[host.schemaVersion] = struct{}{}
-		}
+			for _, row := range rows {
+				host, err := c.session.hostInfoFromMap(row, &HostInfo{connectAddress: c.host.ConnectAddress(), port: c.session.cfg.Port})
+				if err != nil {
+					goto cont
+				}
+				if !isValidPeer(host) || host.schemaVersion == "" {
+					c.logger.Printf("invalid peer or peer with empty schema_version: peer=%q", host)
+					continue
+				}
 
-		if err = iter.Close(); err != nil {
-			goto cont
+				versions[host.schemaVersion] = struct{}{}
+			}
+
+			if err = iter.Close(); err != nil {
+				goto cont
+			}
 		}
 
 		iter = c.query(ctx, localSchemas)

disable_host_lookup_test.go

@@ -0,0 +1,84 @@
+package gocql
+
+import (
+	"fmt"
+	"log"
+	"testing"
+	"time"
+)
+
+func TestDisableHostLookup(t *testing.T) {
+	cluster := createCluster()
+	cluster.DisableHostLookup = true
+
+	cluster.NumConns = 1
+	session := createSessionFromCluster(cluster, t)
+	defer session.Close()
+
+	if err := createTable(session, "CREATE TABLE IF NOT EXISTS gocql_test.test_table (id int primary key)"); err != nil {
+		t.Fatal(err)
+	}
+	if err := session.Query("insert into gocql_test.test_table (id) values (?)", 123).Exec(); err != nil {
+		t.Error(err)
+		return
+	}
+
+	go simulateHeartbeatFailure(session)
+
+	queryCycles := 20
+	for ; queryCycles > 0; queryCycles-- {
+		time.Sleep(2 * time.Second)
+		queryTestKeyspace(session)
+		triggerSchemaChange(session)
+	}
+}
+
+func queryTestKeyspace(session *Session) {
+	iter := session.Query("SELECT * FROM gocql_test.test_table").Iter()
+
+	var id string
+	for iter.Scan(&id) {
+		fmt.Printf("id: %s\n", id)
+	}
+	if err := iter.Close(); err != nil {
+		log.Printf("error querying: %v", err)
+	}
+}
+
+func triggerSchemaChange(session *Session) {
+	// Create a keyspace to trigger schema agreement
+	err := session.Query(`CREATE KEYSPACE IF NOT EXISTS test_keyspace WITH replication = {'class': 'SimpleStrategy', 'replication_factor' : 1}`).Exec()
+	if err != nil {
+		log.Printf("unable to create keyspace: %v", err)
+	}
+
+	// Alter the keyspace to trigger schema agreement
+	err = session.Query(`ALTER KEYSPACE test_keyspace WITH replication = {'class': 'SimpleStrategy', 'replication_factor' : 2}`).Exec()
+	if err != nil {
+		log.Printf("unable to alter keyspace: %v", err)
+	}
+
+	// Drop the keyspace after schema agreement
+	err = session.Query(`DROP KEYSPACE IF EXISTS test_keyspace`).Exec()
+	if err != nil {
+		log.Printf("unable to drop keyspace: %v", err)
+	}
+}
+
+func simulateHeartbeatFailure(session *Session) {
+	time.Sleep(20 * time.Second) // simulate 20 seconds of normal operation
+	log.Println("Simulating heartbeat failure...")
+	cluster := session.cfg
+	session.Close() // close the session to simulate a heartbeat failure
+
+	time.Sleep(10 * time.Second) // wait for 10 seconds to simulate downtime
+
+	// Reconnect
+	log.Println("Reconnecting...")
+	newSession, err := cluster.CreateSession()
+	if err != nil {
+		log.Fatalf("unable to create session: %v", err)
+	}
+	*session = *newSession
+	log.Println("Reconnected")
+}

host_source.go

@@ -635,6 +635,11 @@ func (r *ringDescriber) getClusterPeerInfo(localHost *HostInfo) ([]*HostInfo, er
 		return nil, errNoControl
 	}
 
+	// Check if host lookup is disabled
+	if r.session.cfg.DisableHostLookup {
+		return []*HostInfo{}, nil
+	}
+
 	var peers []*HostInfo
 	iter := r.session.control.withConnHost(func(ch *connHost) *Iter {
 		return ch.conn.querySystemPeers(context.TODO(), localHost.version)

session.go

@@ -237,7 +237,7 @@ func (s *Session) init() error {
 			return err
 		}
 
-		if !s.cfg.DisableInitialHostLookup {
+		if !s.cfg.DisableHostLookup {
 			var partitioner string
 			newHosts, partitioner, err := s.hostSource.GetHosts()
 			if err != nil {
@@ -336,11 +336,11 @@ func (s *Session) init() error {
 		go s.reconnectDownedHosts(s.cfg.ReconnectInterval)
 	}
 
-	// If we disable the initial host lookup, we need to still check if the
+	// If we disable the host lookup, we need to still check if the
 	// cluster is using the newer system schema or not... however, if control
 	// connection is disable, we really have no choice, so we just make our
 	// best guess...
-	if !s.cfg.disableControlConn && s.cfg.DisableInitialHostLookup {
+	if !s.cfg.disableControlConn && s.cfg.DisableHostLookup {
 		newer, _ := checkSystemSchema(s.control)
 		s.useSystemSchema = newer
 	} else {