Skip to content

WIP CASSGO-29#1847

Closed
OleksiienkoMykyta wants to merge 1 commit into
apache:trunkfrom
OleksiienkoMykyta:issue-465-refactor-packages-to-separate-frontend-api-to-backend-internal-api
Closed

WIP CASSGO-29#1847
OleksiienkoMykyta wants to merge 1 commit into
apache:trunkfrom
OleksiienkoMykyta:issue-465-refactor-packages-to-separate-frontend-api-to-backend-internal-api

Conversation

@OleksiienkoMykyta

Copy link
Copy Markdown
Contributor

Closes #465

@OleksiienkoMykyta

Copy link
Copy Markdown
Contributor Author

@joao-r-reis, could you please check it out? It is still a little bit muddy, but it is more about the architecture. Also, I use type aliases to provide users with functionality that should be able to use, but can't be easily separated from internal logic.

@joao-r-reis joao-r-reis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this will be harder than I thought. There's a lot of issues that I can see in this diff because previously exported stuff is going into an internal package.

Let's try a different approach, instead of trying to do the separation between "public" and "internal" + partioning code into different packages at the same time let's focus only on having a single internal package and let's move everything that we see is possible to move (and is unexported) to that new internal package.

We can worry about creating multiple internal packages afterwards, the difficult and complex part is making this separation of public and internal so let's focus on that first.

In this first draft let's keep everything that is exported on the public gocql package for now.

@joao-r-reis joao-r-reis changed the title WIP WIP CASSGO-29 Dec 6, 2024
@OleksiienkoMykyta

Copy link
Copy Markdown
Contributor Author

Hmm this will be harder than I thought. There's a lot of issues that I can see in this diff because previously exported stuff is going into an internal package.

Let's try a different approach, instead of trying to do the separation between "public" and "internal" + partioning code into different packages at the same time let's focus only on having a single internal package and let's move everything that we see is possible to move (and is unexported) to that new internal package.

We can worry about creating multiple internal packages afterwards, the difficult and complex part is making this separation of public and internal so let's focus on that first.

In this first draft let's keep everything that is exported on the public gocql package for now.

Okay, I will make one more implementation, and then we can compare it.

@OleksiienkoMykyta

Copy link
Copy Markdown
Contributor Author

It should be closed in favor of #1857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CASSGO-29 refactor packages to separate frontend api to backend internal api

2 participants