Reduce probability of intermittent failures in WriteWarningsSnapshotTest

minal-kyada · beobal · commit 4134d72a5a35 · 2026-04-15T08:12:03.000+01:00
Patch by Minal Kyada; reviewed by Sam Tunnicliffe and Caleb Rackliffe for CASSANDRA-21263
diff --git a/test/unit/org/apache/cassandra/service/writes/thresholds/WriteWarningsSnapshotTest.java b/test/unit/org/apache/cassandra/service/writes/thresholds/WriteWarningsSnapshotTest.java
@@ -175,11 +175,10 @@ private static Gen<WriteWarningsSnapshot> nonEmpty()
 
     private static Gen<WriteThresholdCounter> counter()
     {
-        Gen<Boolean> isEmpty = SourceDSL.booleans().all();
         Constraint maxValue = Constraint.between(1, Long.MAX_VALUE);
         Gen<WriteThresholdCounter> gen = rs ->
         {
-            if (isEmpty.generate(rs))
+            if (rs.next(Constraint.between(0, 3)) == 0)
                 return WriteThresholdCounter.empty();
             Map<TableId, Long> values = new HashMap<>();
             values.put(TABLE1, rs.next(maxValue));

Original file line number	Diff line number	Diff line change
`@@ -175,11 +175,10 @@ private static Gen<WriteWarningsSnapshot> nonEmpty()`
`175`	`175`
`176`	`176`	`private static Gen<WriteThresholdCounter> counter()`
`177`	`177`	`{`
`178`		`- Gen<Boolean> isEmpty = SourceDSL.booleans().all();`
`179`	`178`	`Constraint maxValue = Constraint.between(1, Long.MAX_VALUE);`
`180`	`179`	`Gen<WriteThresholdCounter> gen = rs ->`
`181`	`180`	`{`
`182`		`- if (isEmpty.generate(rs))`
	`181`	`+ if (rs.next(Constraint.between(0, 3)) == 0)`
`183`	`182`	`return WriteThresholdCounter.empty();`
`184`	`183`	`Map<TableId, Long> values = new HashMap<>();`
`185`	`184`	`values.put(TABLE1, rs.next(maxValue));`