CASSANDRA-21425: Fix skipped tests and typos in CassandraRoleManagerTest#4857
Open
arvindKandpal-ksolves wants to merge 1 commit into
Open
CASSANDRA-21425: Fix skipped tests and typos in CassandraRoleManagerTest#4857arvindKandpal-ksolves wants to merge 1 commit into
arvindKandpal-ksolves wants to merge 1 commit into
Conversation
…Test Adds missing @test annotations to testPasswordUpdateRateLimiting and testPasswordUpdateRateLimitingDisabled. Also fixes minor typos in comments and assertion strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix skipped tests (missing @ Test) and typos in CassandraRoleManagerTest
Context & Changes:
While reviewing
CassandraRoleManagerTest.java, I noticed a few minor issues that this patch addresses to improve test coverage and code consistency:@Testannotations totestPasswordUpdateRateLimiting()andtestPasswordUpdateRateLimitingDisabled(), which were previously being silently skipped by JUnit.role_b3->role_b_3).OverloadedExceptionassertion message ("100ms. "->"100ms.") so it correctly matches the system's actual exception string.primitive->primitives).Testing:
ant test -Dtest.name=CassandraRoleManagerTest.patch by Arvind Kandpal; reviewed by TBD for CASSANDRA-21425