Skip to content

CASSANDRA-21425: Fix skipped tests and typos in CassandraRoleManagerTest #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arvindKandpal-ksolves wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

CASSANDRA-21425: Fix skipped tests and typos in CassandraRoleManagerTest #4857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/unit/org/apache/cassandra/auth/CassandraRoleManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public void setup() throws Exception
public void getGrantedRolesImplMinimizesReads()
{
// IRoleManager::getRoleDetails was not in the initial API, so a default impl
// was added which uses the existing methods on IRoleManager as primitive to
// was added which uses the existing methods on IRoleManager as primitives to
// construct the Role objects. While this will work for any IRoleManager impl
// it is inefficient, so CassandraRoleManager has its own implementation which
// collects all of the necessary info with a single query for each granted role.
Expand All @@ -104,7 +104,7 @@ public void getGrantedRolesImplMinimizesReads()
fetchRolesAndCheckReadCount(roleManager, ROLE_A);

// Check that when granted roles appear multiple times in parallel levels of the hierarchy, we don't
// do redundant reads. E.g. here role_b_1, role_b_2 and role_b3 are granted to both role_b and role_c
// do redundant reads. E.g. here role_b_1, role_b_2 and role_b_3 are granted to both role_b and role_c
// but we only want to actually read them once
grantRolesTo(roleManager, ROLE_C, ROLE_B_1, ROLE_B_2, ROLE_B_3);
fetchRolesAndCheckReadCount(roleManager, ROLE_A);
Expand Down Expand Up @@ -165,6 +165,7 @@ public void warmCacheLoadsAllEntries()
}
}

@Test
public void testPasswordUpdateRateLimiting() throws Exception
{
try
Expand Down Expand Up @@ -194,7 +195,7 @@ public void testPasswordUpdateRateLimiting() throws Exception
}
catch (OverloadedException e)
{
assertEquals("Password for role test_password_role can only be changed every 100ms. ", e.getMessage());
assertEquals("Password for role test_password_role can only be changed every 100ms.", e.getMessage());
}

// Wait for the rate limit interval to pass
Expand Down Expand Up @@ -301,6 +302,7 @@ public void ctorInvalidRoleDisconnectOptions()
Assertions.assertThat(crm.getInvalidClientDisconnectMaxJitterMillis()).isEqualTo(1000);
}

@Test
public void testPasswordUpdateRateLimitingDisabled() throws Exception
{
try
Expand Down