CASSANDRA-21426: AssertionError in hasReplicaWithOngoingRepair when parallel_repair_count > 1#4858
Open
patrickclee0207 wants to merge 1 commit into
Open
Conversation
…n parallel_repair_count > 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An assetion error is thrown from AutoRepairUtils.java when calling StorageService.instance.getTokenMetadata(). works fine when only 1 node is allowed parallel_repair_count: 1. When you increase this > 1 you start getting the assertion error
the change is to instead use StorageService.instance.getTokenMetadata().cachedOnlyTokenMap()
patch by Patrick Lee; reviewed by TBD for CASSANDRA-21426
using CCM and 9 nodes, with the auto-repair config
you can reproduce and get the assertion error. running the same in CCM with the patched version validates that there are no assertion errors and there were 2 nodes running incremental repairs concurrently.