Skip to content

Commit 05aa4ca

Browse files
address comments of claude from RexXiong
1 parent 6e65966 commit 05aa4ca

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,7 @@ class FetchHandler(
148148
val endIndices = openStreamList.getEndIndexList
149149
val readLocalFlags = openStreamList.getReadLocalShuffleList
150150
val pbOpenStreamListResponse = PbOpenStreamListResponse.newBuilder()
151-
val applicationId = Utils.splitShuffleKey(shuffleKey)._1
152-
Utils.validateAppId(applicationId)
153-
checkAuth(client, applicationId)
151+
checkAuth(client, Utils.splitShuffleKey(shuffleKey)._1)
154152
val openStreamRequestId = Utils.makeOpenStreamRequestId(
155153
shuffleKey,
156154
client.getChannel.id().toString,
@@ -366,9 +364,7 @@ class FetchHandler(
366364
isLegacy: Boolean,
367365
readLocalShuffle: Boolean = false,
368366
callback: RpcResponseCallback): Unit = {
369-
val applicationId = Utils.splitShuffleKey(shuffleKey)._1
370-
Utils.validateAppId(applicationId)
371-
checkAuth(client, applicationId)
367+
checkAuth(client, Utils.splitShuffleKey(shuffleKey)._1)
372368
workerSource.recordAppActiveConnection(client, shuffleKey)
373369
val requestId = Utils.makeOpenStreamRequestId(
374370
shuffleKey,

worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -988,9 +988,7 @@ class PushDataHandler(val workerSource: WorkerSource) extends BaseMessageHandler
988988
shuffleKey: String,
989989
handler: () => Unit,
990990
callback: RpcResponseCallback): Unit = {
991-
val applicationId = Utils.splitShuffleKey(shuffleKey)._1
992-
Utils.validateAppId(applicationId)
993-
checkAuth(client, applicationId)
991+
checkAuth(client, Utils.splitShuffleKey(shuffleKey)._1)
994992
try {
995993
handler()
996994
} catch {

0 commit comments

Comments
 (0)