Skip to content

Commit 017b06b

Browse files
andr-sokolovtuhaihe
authored andcommitted
Fix and run gp_exttable_fdw tests
Replace "format" with "format_type", because the format option is not supported
1 parent 103da7a commit 017b06b

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/build-cloudberry.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,8 @@ jobs:
312312
"gpcontrib/pxf_fdw:installcheck",
313313
"gpcontrib/zstd:installcheck",
314314
"gpcontrib/gp_sparse_vector:installcheck",
315-
"gpcontrib/gp_toolkit:installcheck"]
315+
"gpcontrib/gp_toolkit:installcheck",
316+
"gpcontrib/gp_exttable_fdw:installcheck"]
316317
},
317318
{"test":"ic-fixme",
318319
"make_configs":["src/test/regress:installcheck-fixme"],

gpcontrib/gp_exttable_fdw/input/gp_exttable_fdw.source

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ SELECT * FROM tableless_ext_fdw;
7272
-- When using CREATE FOREIGN TABLE syntax, '|' and '\' need to be escaped as '|' --> '\|' and '|' --> '\\'.
7373
CREATE FOREIGN TABLE ext_special_uri(a int, b int)
7474
SERVER gp_exttable_server
75-
OPTIONS (format 'csv', delimiter ',',
75+
OPTIONS (format_type 'c', delimiter ',',
7676
location_uris 'file://@hostname@@abs_srcdir@/data/spe\\cial1\||file://@hostname@@abs_srcdir@/data/\|special2\\');
7777
\a
7878
SELECT urilocation FROM pg_exttable WHERE reloid = 'public.ext_special_uri'::regclass;

gpcontrib/gp_exttable_fdw/output/gp_exttable_fdw.source

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ SELECT * FROM tableless_ext_fdw;
7676
-- When using CREATE FOREIGN TABLE syntax, '|' and '\' need to be escaped as '|' --> '\|' and '|' --> '\\'.
7777
CREATE FOREIGN TABLE ext_special_uri(a int, b int)
7878
SERVER gp_exttable_server
79-
OPTIONS (format 'csv', delimiter ',',
79+
OPTIONS (format_type 'c', delimiter ',',
8080
location_uris 'file://@hostname@@abs_srcdir@/data/spe\\cial1\||file://@hostname@@abs_srcdir@/data/\|special2\\');
8181
\a
8282
SELECT urilocation FROM pg_exttable WHERE reloid = 'public.ext_special_uri'::regclass;
@@ -85,7 +85,7 @@ urilocation
8585
(1 row)
8686
SELECT ftoptions FROM pg_foreign_table WHERE ftrelid='public.ext_special_uri'::regclass;
8787
ftoptions
88-
{format=csv,"delimiter=,","location_uris=file://@hostname@@abs_srcdir@/data/spe\\\\cial1\\||file://@hostname@@abs_srcdir@/data/\\|special2\\\\"}
88+
{format_type=c,"delimiter=,","location_uris=file://@hostname@@abs_srcdir@/data/spe\\\\cial1\\||file://@hostname@@abs_srcdir@/data/\\|special2\\\\"}
8989
(1 row)
9090
\a
9191
SELECT * FROM ext_special_uri ORDER BY a;

0 commit comments

Comments
 (0)