Fix ORCA permission checking crash with RTEPermissionInfo

1. orca.c: transformGroupedWindows() incorrectly created an RTEPermissionInfo
   with relid=0 for a subquery RTE. Per PG16 commit a61b1f7, only
   RTE_RELATION entries need RTEPermissionInfo. This caused
   Assert(OidIsValid(perminfo->relid)) failure when ORCA translated
   ROLLUP + window function queries.

2. matview.c: replace_rte_with_delta() converted RTE_RELATION to
   RTE_SUBQUERY but forgot to clear perminfoindex, causing
   Assert(rte->rtekind == RTE_RELATION || ...) failure during IVM
   incremental maintenance with ORCA enabled.

Also fix subquery not inheriting rteperminfos, and correct
AddPerfmInfo/Perfission typos.

Author: liushengsong

src/backend/commands/matview.c

@@ -2340,6 +2340,7 @@ get_prestate_rte(RangeTblEntry *rte, MV_TriggerTable *table,
 	rte->relkind = 0;
 	rte->rellockmode = 0;
 	rte->tablesample = NULL;
+	rte->perminfoindex = 0;		/* subquery RTE does not need permission check */
 	rte->inh = false;			/* must not be set for a subquery */
 
 	return rte;
@@ -2403,6 +2404,7 @@ replace_rte_with_delta(RangeTblEntry *rte, MV_TriggerTable *table, bool is_new,
 	rte->relkind = 0;
 	rte->rellockmode = 0;
 	rte->tablesample = NULL;
+	rte->perminfoindex = 0;		/* subquery RTE does not need permission check */
 	rte->inh = false;			/* must not be set for a subquery */
 
 	return rte;

src/backend/gpopt/gpdbwrappers.cpp

@@ -2818,11 +2818,12 @@ gpdb::TestexprIsHashable(Node *testexpr, List *param_ids)
 }
 
 RTEPermissionInfo *
-gpdb::GetRTEPermissionInfo(List *rteperminfos,
-											   const RangeTblEntry *rte)
+gpdb::GetRTEPermissionInfo(List *rteperminfos, const RangeTblEntry *rte)
 {
 	GP_WRAP_START;
 	{
+		// Cast away const: upstream getRTEPermissionInfo() only reads
+		// rte->perminfoindex and rte->relid but its signature lacks const.
 		return getRTEPermissionInfo(rteperminfos, (RangeTblEntry *) rte);
 	}
 	GP_WRAP_END;

src/backend/gpopt/translate/CContextDXLToPlStmt.cpp

@@ -594,16 +594,16 @@ CContextDXLToPlStmt::GetRTEIndexByAssignedQueryId(
 
 //---------------------------------------------------------------------------
 //	@function:
-//		CContextDXLToPlStmt::AddPerfmInfo
+//		CContextDXLToPlStmt::AddPermInfo
 //
 //	@doc:
-//		Add a Perfission Info list entry
+//		Add a Permission Info list entry
 //
 //---------------------------------------------------------------------------
 void
-CContextDXLToPlStmt::AddPerfmInfo(RTEPermissionInfo *pi)
+CContextDXLToPlStmt::AddPermInfo(RTEPermissionInfo *pi)
 {
-	// add rte to rtable entries list
+	// add permission info to list
 	m_perminfo_list = gpdb::LAppend(m_perminfo_list, pi);
 }
 

src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp

@@ -5336,7 +5336,7 @@ CTranslatorDXLToPlStmt::ProcessDXLTblDescr(
 	rte->eref = alias;
 	rte->alias = alias;
 
-	m_dxl_to_plstmt_context->AddPerfmInfo(pi);
+	m_dxl_to_plstmt_context->AddPermInfo(pi);
 
 	// set up rte <> perm info link.
 	rte->perminfoindex = gpdb::ListLength(

src/backend/optimizer/plan/orca.c

@@ -518,7 +518,6 @@ transformGroupedWindows(Node *node, void *context)
 
 		Query	   *subq;
 		RangeTblEntry *rte;
-		RTEPermissionInfo *perminfo;
 		RangeTblRef *ref;
 		Alias	   *alias;
 		bool		hadSubLinks = qry->hasSubLinks;
@@ -545,6 +544,7 @@ transformGroupedWindows(Node *node, void *context)
 
 		/* Core of subquery input table expression: */
 		subq->rtable = qry->rtable; /* before windowing */
+		subq->rteperminfos = qry->rteperminfos; /* before windowing */
 		subq->jointree = qry->jointree; /* before windowing */
 		subq->targetList = NIL;		/* fill in later */
 
@@ -578,11 +578,9 @@ transformGroupedWindows(Node *node, void *context)
 		rte->eref = NULL;			/* fill in later */
 		rte->inFromCl = true;
 
-		perminfo = makeNode(RTEPermissionInfo);
-		perminfo->requiredPerms = ACL_SELECT;
-
 		/*
-		 * Default? rte->inh = 0; rte->checkAsUser = 0;
+		 * Subquery RTEs do not need RTEPermissionInfo.  Permission checks
+		 * are performed on the base tables within the subquery itself.
 		 */
 
 		/*
@@ -605,7 +603,7 @@ transformGroupedWindows(Node *node, void *context)
 
 		/* Core of outer query input table expression: */
 		qry->rtable = list_make1(rte);
-		qry->rteperminfos = list_make1(perminfo);
+		qry->rteperminfos = NIL;
 		qry->jointree = (FromExpr *) makeNode(FromExpr);
 		qry->jointree->fromlist = list_make1(ref);
 		qry->jointree->quals = NULL;

src/include/gpopt/translate/CContextDXLToPlStmt.h

@@ -109,7 +109,7 @@ class CContextDXLToPlStmt
 	// list of all rtable entries
 	List *m_rtable_entries_list;
 
-	// list of all rtable entries
+	// list of all RTEPermissionInfo entries
 	List *m_perminfo_list;
 
 	// list of all subplan entries
@@ -249,8 +249,8 @@ class CContextDXLToPlStmt
 	Index GetRTEIndexByAssignedQueryId(ULONG assigned_query_id_for_target_rel,
 									   BOOL *is_rte_exists);
 
-	// add a perm info.
-	void AddPerfmInfo(RTEPermissionInfo *pi);
+	// add a permission info entry
+	void AddPermInfo(RTEPermissionInfo *pi);
 
 	// get perm info from m_perminfo_list by given index
 	RTEPermissionInfo *GetPermInfoByIndex(Index index);