Skip to content

Commit c6072c4

Browse files
author
Vladislav Shchetinin
committed
Fix: adapt Makefile, fix uninitialized var
1 parent 910ecbb commit c6072c4

3 files changed

Lines changed: 12 additions & 4 deletions

File tree

gpcontrib/gp_relsizes_stats/Makefile

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@ REGRESS = grants gp_relsizes_stats
77
REGRESS_OPTS = --inputdir=test/
88
PGFILEDESC = "gp_relsizes_stats - an extension to track table on-disc sizes in greenplum"
99
PG_CXXFLAGS += $(COMMON_CPP_FLAGS)
10-
PG_CONFIG = pg_config
11-
PGXS := $(shell $(PG_CONFIG) --pgxs)
10+
ifdef USE_PGXS
11+
PG_CONFIG = pg_config
12+
PGXS := $(shell $(PG_CONFIG) --pgxs)
1213
include $(PGXS)
14+
else
15+
subdir = gpcontrib/gp_relsizes_stats
16+
top_builddir = ../..
17+
include $(top_builddir)/src/Makefile.global
18+
include $(top_srcdir)/contrib/contrib-global.mk
19+
endif
20+

gpcontrib/gp_relsizes_stats/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ make && make install
2222

2323
### Confguration
2424
gp_relsizes_stats configuration parameters:
25-
| **Parameter** | **Type** | **Default** | **Default** |
25+
| **Parameter** | **Type** | **Default** | **Description** |
2626
| ---------------- | --------------- | ------------ | ------------ |
2727
| `gp_relsizes_stats.enabled` | bool | false | Using `gp_relsizes_stats.enabled` you can enable/disable background stats collection for database where extension installed (actually enable/disable background worker which collecting stats).|
2828
| `gp_relsizes_stats.restart_naptime` | int | 21600000 | Using `gp_relsizes_stats.restart_naptime` you can set naptime between each startup of collecting process. Value set time in milliseconds. Default is equal to 6 hours.|

gpcontrib/gp_relsizes_stats/src/gp_relsizes_stats.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ static void worker_sigterm(SIGNAL_ARGS) {
110110
* Returns BGWH_STOPPED on success, BGWH_POSTMASTER_DIED on error/timeout.
111111
*/
112112
static BgwHandleStatus WaitForBackgroundWorkerShutdownSafely(BackgroundWorkerHandle *handle) {
113-
BgwHandleStatus status;
113+
BgwHandleStatus status = BGWH_NOT_YET_STARTED;
114114
int rc;
115115
int attempts = 0;
116116
const int max_attempts = 5 * HOUR_TIME / 100; /* maximum 5 hours wait time */

0 commit comments

Comments
 (0)