WIP: Add hooks to support extensible interconnect#1375
Closed
gfphoenix78 wants to merge 1 commit into
Closed
Conversation
The interconnect module is traditionally single-thread. It's hard
to refactor/replace the current implementation for thread-safe.
This commit adds hooks to support extensible interconnect. The hooks
contain 3 functions in struct ExtInterconnectFuncs:
struct ExtInterconnectFuncs {
void (*init)();
int (*port)();
void (*exit)();
};
init: create socket to receive interconnect packets.
port: return the port number created in init.
exit: disconnect all interconnections and cleanup related resources.
my-ship-it
reviewed
Oct 14, 2025
| * | ||
| * NB: Use malloc/free, not palloc/pfree, for the items below. | ||
| */ | ||
| uint32 motionListener; /* interconnect listener port */ |
Contributor
There was a problem hiding this comment.
Unnecessary format changes
Contributor
Author
There was a problem hiding this comment.
The mix usage of tabs and spaces messes up the code.
Contributor
There was a problem hiding this comment.
So do we need to keep the original format consistent with the rest of the structure?
my-ship-it
approved these changes
Oct 14, 2025
Contributor
my-ship-it
left a comment
my-ship-it
left a comment
There was a problem hiding this comment.
LGTM except one minor comment
gfphoenix78
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interconnect module is traditionally single-thread. It's hard to refactor/replace the current implementation for thread-safe.
This commit adds hooks to support extensible interconnect. The hooks contain 3 functions in struct ExtInterconnectFuncs:
struct ExtInterconnectFuncs {
void (*init)();
int (*port)();
void (*exit)();
};
init: create socket to receive interconnect packets.
port: return the port number created in init.
exit: disconnect all interconnections and cleanup related resources.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions