Skip to content

pg_dump/psql: properly recognize GP#1662

Merged
tuhaihe merged 1 commit intomainfrom
pgupgrade_fixes
Apr 9, 2026
Merged

pg_dump/psql: properly recognize GP#1662
tuhaihe merged 1 commit intomainfrom
pgupgrade_fixes

Conversation

@Smyatkin-Maxim
Copy link
Copy Markdown
Contributor

@Smyatkin-Maxim Smyatkin-Maxim commented Apr 3, 2026

During a batch rebranding from Greenplum to Cloudberry we've lost ability to work with Greenplum in pg_dump and psql

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel
  • Additionally - manual gpupgrade run gp6 -> cb.

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

I've started working on gpupgrade support for an in-place upgrade from gp6 to cloudberry, this issue is one of many that need to be fixed (though most issues are in gpupgrade itself, not in core cloudberry code.

CI Skip Instructions


@reshke
Copy link
Copy Markdown
Contributor

reshke commented Apr 4, 2026

We need to take pg_dump from GP 6 during pg_upgrade, so +1

Copy link
Copy Markdown
Contributor

@leborchuk leborchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could upgrade from various GP forks (archived GP/WarehousePG/Greengage), so check not only Cloudberry substring in version

During a batch rebranding from Greenplum to Cloudberry we've lost
ability to work with Greenplum from pg_dump and psql
@tuhaihe
Copy link
Copy Markdown
Member

tuhaihe commented Apr 9, 2026

All tests passed, and this PR got approved. Let's merge it!

@tuhaihe tuhaihe merged commit 880b13e into main Apr 9, 2026
66 of 67 checks passed
@tuhaihe tuhaihe deleted the pgupgrade_fixes branch April 9, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants