Change bypassvlanoverlapcheck to bypass_vlan_overlap_check for naming consistency

The parameter name has been changed from camelCase (bypassvlanoverlapcheck)
to snake_case (bypass_vlan_overlap_check) to maintain consistency with other
resource arguments like ip_address, physical_network_id, and acl_id.

This change affects:
- Resource schema definition
- Resource creation logic
- Test cases and assertions
- Documentation examples

The parameter is now also marked as ForceNew since it can only be set during
gateway creation and cannot be modified afterwards.

Author: bhouse-nexthop

cloudstack/resource_cloudstack_private_gateway.go

@@ -86,10 +86,11 @@ func resourceCloudStackPrivateGateway() *schema.Resource {
 				ForceNew: true,
 			},
 
-			"bypassvlanoverlapcheck": {
+			"bypass_vlan_overlap_check": {
 				Type:     schema.TypeBool,
 				Optional: true,
 				Default:  false,
+				ForceNew: true,
 			},
 		},
 	}
@@ -125,9 +126,9 @@ func resourceCloudStackPrivateGatewayCreate(d *schema.ResourceData, meta interfa
 		p.SetAclid(aclid.(string))
 	}
 
-	// Set bypassvlanoverlapcheck if specified
-	if bypassvlanoverlapcheck, ok := d.GetOk("bypassvlanoverlapcheck"); ok {
-		p.SetBypassvlanoverlapcheck(bypassvlanoverlapcheck.(bool))
+	// Set bypass_vlan_overlap_check if specified
+	if bypassVlanOverlapCheck, ok := d.GetOk("bypass_vlan_overlap_check"); ok {
+		p.SetBypassvlanoverlapcheck(bypassVlanOverlapCheck.(bool))
 	}
 
 	// Create the new private gateway

cloudstack/resource_cloudstack_private_gateway_test.go

@@ -62,7 +62,7 @@ func TestAccCloudStackPrivateGateway_import(t *testing.T) {
 				ResourceName:            "cloudstack_private_gateway.foo",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"bypassvlanoverlapcheck"},
+				ImportStateVerifyIgnore: []string{"bypass_vlan_overlap_check"},
 			},
 		},
 	})
@@ -82,7 +82,7 @@ func TestAccCloudStackPrivateGateway_bypassVlanOverlapCheck(t *testing.T) {
 					testAccCheckCloudStackPrivateGatewayExists(
 						"cloudstack_private_gateway.bar", &gateway),
 					resource.TestCheckResourceAttr(
-						"cloudstack_private_gateway.bar", "bypassvlanoverlapcheck", "true"),
+						"cloudstack_private_gateway.bar", "bypass_vlan_overlap_check", "true"),
 				),
 			},
 		},
@@ -103,7 +103,7 @@ func TestAccCloudStackPrivateGateway_bypassVlanOverlapCheckDefault(t *testing.T)
 					testAccCheckCloudStackPrivateGatewayExists(
 						"cloudstack_private_gateway.foo", &gateway),
 					resource.TestCheckResourceAttr(
-						"cloudstack_private_gateway.foo", "bypassvlanoverlapcheck", "false"),
+						"cloudstack_private_gateway.foo", "bypass_vlan_overlap_check", "false"),
 				),
 			},
 		},
@@ -225,6 +225,6 @@ resource "cloudstack_private_gateway" "bar" {
   vlan = "2"
   vpc_id = cloudstack_vpc.bar.id
   acl_id = cloudstack_network_acl.bar.id
-  bypassvlanoverlapcheck = true
+  bypass_vlan_overlap_check = true
   depends_on = ["cloudstack_vpc.bar","cloudstack_network_acl.bar"]
 }`

website/docs/r/private_gateway.html.markdown

@@ -29,13 +29,13 @@ Example with VLAN overlap check bypass:
 
 ```hcl
 resource "cloudstack_private_gateway" "with_bypass" {
-  gateway                   = "10.0.0.1"
-  ip_address                = "10.0.0.2"
-  netmask                   = "255.255.255.252"
-  vlan                      = "200"
-  vpc_id                    = "76f6e8dc-07e3-4971-b2a2-8831b0cc4cb4"
-  acl_id                    = "cf4f1dad-aade-4ccd-866c-0a2166e5be3d"
-  bypassvlanoverlapcheck    = true
+  gateway                      = "10.0.0.1"
+  ip_address                   = "10.0.0.2"
+  netmask                      = "255.255.255.252"
+  vlan                         = "200"
+  vpc_id                       = "76f6e8dc-07e3-4971-b2a2-8831b0cc4cb4"
+  acl_id                       = "cf4f1dad-aade-4ccd-866c-0a2166e5be3d"
+  bypass_vlan_overlap_check    = true
 }
 ```
 
@@ -65,10 +65,10 @@ The following arguments are supported:
 * `vpc_id` - (Required) The VPC ID in which to create this Private gateway. Changing
     this forces a new resource to be created.
 
-* `bypassvlanoverlapcheck` - (Optional) When set to true, bypasses the VLAN overlap
+* `bypass_vlan_overlap_check` - (Optional) When set to true, bypasses the VLAN overlap
     check during private gateway creation. This allows creating private gateways with
     VLANs that may overlap with existing VLANs in the physical network. Defaults to
-    false.
+    false. Changing this forces a new resource to be created.
 
 ## Attributes Reference