Add terraform import support for several cloudstack resources

Author: Pearl Dsilva

cloudstack/resource_cloudstack_autoscale_policy.go

@@ -34,6 +34,9 @@ func resourceCloudStackAutoScalePolicy() *schema.Resource {
 		Read:   resourceCloudStackAutoScalePolicyRead,
 		Update: resourceCloudStackAutoScalePolicyUpdate,
 		Delete: resourceCloudStackAutoScalePolicyDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
 
 		Schema: map[string]*schema.Schema{
 			"name": {

cloudstack/resource_cloudstack_autoscale_vm_group.go

@@ -35,6 +35,9 @@ func resourceCloudStackAutoScaleVMGroup() *schema.Resource {
 		Read:   resourceCloudStackAutoScaleVMGroupRead,
 		Update: resourceCloudStackAutoScaleVMGroupUpdate,
 		Delete: resourceCloudStackAutoScaleVMGroupDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
 
 		Schema: map[string]*schema.Schema{
 			"lbrule_id": {

cloudstack/resource_cloudstack_autoscale_vm_profile.go

@@ -35,6 +35,9 @@ func resourceCloudStackAutoScaleVMProfile() *schema.Resource {
 		Read:   resourceCloudStackAutoScaleVMProfileRead,
 		Update: resourceCloudStackAutoScaleVMProfileUpdate,
 		Delete: resourceCloudStackAutoScaleVMProfileDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
 
 		Schema: map[string]*schema.Schema{
 			"service_offering": {

cloudstack/resource_cloudstack_autoscale_vm_profile_test.go

@@ -85,6 +85,27 @@ func TestAccCloudStackAutoscaleVMProfile_update(t *testing.T) {
 	})
 }
 
+func TestAccCloudStackAutoscaleVMProfile_import(t *testing.T) {
+	t.Skip("Skipping due to bug in cloudstack-go library")
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckCloudStackAutoscaleVMProfileDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCloudStackAutoscaleVMProfile_basic,
+			},
+
+			{
+				ResourceName:      "cloudstack_autoscale_vm_profile.foo",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func testAccCheckResourceMetadata(vmProfile *cloudstack.AutoScaleVmProfile) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		cs := testAccProvider.Meta().(*cloudstack.CloudStackClient)

cloudstack/resource_cloudstack_condition.go

@@ -33,6 +33,9 @@ func resourceCloudStackCondition() *schema.Resource {
 		Read:   resourceCloudStackConditionRead,
 		Update: resourceCloudStackConditionUpdate,
 		Delete: resourceCloudStackConditionDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
 
 		Schema: map[string]*schema.Schema{
 			"counter_id": {

cloudstack/resource_cloudstack_counter.go

@@ -32,6 +32,9 @@ func resourceCloudStackCounter() *schema.Resource {
 		Create: resourceCloudStackCounterCreate,
 		Read:   resourceCloudStackCounterRead,
 		Delete: resourceCloudStackCounterDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
 
 		Schema: map[string]*schema.Schema{
 			"name": {

cloudstack/resource_cloudstack_host.go

@@ -37,6 +37,9 @@ func resourceCloudStackHost() *schema.Resource {
 		Update: resourceCloudStackHostUpdate,
 		Create: resourceCloudStackHostCreate,
 		Delete: resourceCloudStackHostDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
 		Schema: map[string]*schema.Schema{
 			"hypervisor": {
 				Type:     schema.TypeString,

cloudstack/resource_cloudstack_host_test.go

@@ -49,6 +49,32 @@ func TestAccCloudStackHost_basic(t *testing.T) {
 	})
 }
 
+func TestAccCloudStackHost_import(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCloudStackHost_basic,
+			},
+
+			{
+				ResourceName:      "cloudstack_host.test",
+				ImportState:       true,
+				ImportStateVerify: true,
+				// CloudStack's listHosts API never returns the connection URL or
+				// credentials, and these timeouts/flags are provider-local knobs that
+				// aren't part of the host object, so Read can't populate any of them.
+				ImportStateVerifyIgnore: []string{
+					"url", "username", "password",
+					"create_timeout", "destroy_timeout",
+					"prevent_destroy", "force_destroy",
+				},
+			},
+		},
+	})
+}
+
 const testAccCloudStackHost_basic = `
 data "cloudstack_zone" "zone" {
 	filter {

cloudstack/resource_cloudstack_ipaddress.go

@@ -33,6 +33,9 @@ func resourceCloudStackIPAddress() *schema.Resource {
 		Create: resourceCloudStackIPAddressCreate,
 		Read:   resourceCloudStackIPAddressRead,
 		Delete: resourceCloudStackIPAddressDelete,
+		Importer: &schema.ResourceImporter{
+			State: importStatePassthrough,
+		},
 
 		Schema: map[string]*schema.Schema{
 			"is_portable": {

cloudstack/resource_cloudstack_ipaddress_test.go

@@ -49,6 +49,25 @@ func TestAccCloudStackIPAddress_basic(t *testing.T) {
 	})
 }
 
+func TestAccCloudStackIPAddress_import(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckCloudStackIPAddressDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCloudStackIPAddress_basic,
+			},
+
+			{
+				ResourceName:      "cloudstack_ipaddress.foo",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func TestAccCloudStackIPAddress_vpc(t *testing.T) {
 	var ipaddr cloudstack.PublicIpAddress