fix test

Author: Pearl1594

cloudstack/data_source_cloudstack_network_offering.go

@@ -149,7 +149,12 @@ func datasourceCloudStackNetworkOfferingRead(d *schema.ResourceData, meta interf
 	}
 	log.Printf("[DEBUG] Selected network offerings: %s\n", networkOffering.Displaytext)
 
-	return networkOfferingDescriptionAttributes(d, networkOffering)
+	fullNetworkOffering, _, err := cs.NetworkOffering.GetNetworkOfferingByName(networkOffering.Name)
+	if err != nil {
+		return fmt.Errorf("Error retrieving full network offering details: %s", err)
+	}
+
+	return networkOfferingDescriptionAttributes(d, fullNetworkOffering)
 }
 
 func networkOfferingDescriptionAttributes(d *schema.ResourceData, networkOffering *cloudstack.NetworkOffering) error {
@@ -169,7 +174,10 @@ func networkOfferingDescriptionAttributes(d *schema.ResourceData, networkOfferin
 	d.Set("specify_as_number", networkOffering.Specifyasnumber)
 	d.Set("internet_protocol", networkOffering.Internetprotocol)
 	d.Set("routing_mode", networkOffering.Routingmode)
-	d.Set("max_connections", networkOffering.Maxconnections)
+
+	if networkOffering.Maxconnections > 0 {
+		d.Set("max_connections", networkOffering.Maxconnections)
+	}
 
 	// Set supported services
 	if len(networkOffering.Service) > 0 {

cloudstack/data_source_cloudstack_network_offering_test.go

@@ -205,7 +205,6 @@ resource "cloudstack_network_offering" "net-off-resource"{
   guest_ip_type     = "Isolated"
   traffic_type      = "Guest"
   enable            = true
-  max_connections   = 256
   supported_services = ["Dhcp", "Dns", "Firewall", "Lb", "SourceNat", "StaticNat", "PortForwarding"]
   service_provider_list = {
     Dhcp           = "VirtualRouter"

cloudstack/resource_cloudstack_network_offering.go

@@ -350,7 +350,6 @@ func resourceCloudStackNetworkOfferingRead(d *schema.ResourceData, meta interfac
 	d.Set("guest_ip_type", n.Guestiptype)
 	d.Set("traffic_type", n.Traffictype)
 
-	// Only set optional attributes if they were specified in the configuration
 	if _, ok := d.GetOk("network_rate"); ok {
 		d.Set("network_rate", n.Networkrate)
 	}
@@ -384,15 +383,14 @@ func resourceCloudStackNetworkOfferingRead(d *schema.ResourceData, meta interfac
 	if _, ok := d.GetOk("routing_mode"); ok {
 		d.Set("routing_mode", n.Routingmode)
 	}
-	// Set max_connections if it was specified in the configuration
-	// Note: CloudStack may return 0 even when a value was set, so we preserve the configured value
-	if configuredMaxConn := d.Get("max_connections").(int); configuredMaxConn != 0 {
-		d.Set("max_connections", configuredMaxConn)
-	} else if n.Maxconnections != 0 {
-		d.Set("max_connections", n.Maxconnections)
+	if _, ok := d.GetOk("max_connections"); ok {
+		log.Printf("[DEBUG] Max connections configured: %d, CloudStack returned: %d", d.Get("max_connections").(int), n.Maxconnections)
+
+		if n.Maxconnections > 0 {
+			d.Set("max_connections", n.Maxconnections)
+		}
 	}
 
-	// Set supported services if specified
 	if _, ok := d.GetOk("supported_services"); ok && len(n.Service) > 0 {
 		services := make([]string, len(n.Service))
 		for i, service := range n.Service {
@@ -401,7 +399,6 @@ func resourceCloudStackNetworkOfferingRead(d *schema.ResourceData, meta interfac
 		d.Set("supported_services", services)
 	}
 
-	// Set service provider list if specified
 	if _, ok := d.GetOk("service_provider_list"); ok && len(n.Service) > 0 {
 		serviceProviders := make(map[string]string)
 		for _, service := range n.Service {