feat: Add automatic project inheritance for cloudstack_instance from network

Implement automatic project inheritance for cloudstack_instance resource:
- Instance inherits project from network_id when no explicit project is set
- Only applies to Advanced networking zones
- Uses projectid=-1 for universal network lookup across projects
- Updates state with inherited project during read operations

Changes:
- Modified resourceCloudStackInstanceCreate to fetch network and inherit project
- Modified resourceCloudStackInstanceRead to set project in state
- Added TestAccCloudStackInstance_networkProjectInheritance test case
- Updated documentation with inheritance behavior and example

All 12 instance acceptance tests passing.

Author: bhouse-nexthop

cloudstack/resource_cloudstack_instance.go

@@ -364,7 +364,19 @@ func resourceCloudStackInstanceCreate(d *schema.ResourceData, meta interface{})
 
 	if zone.Networktype == "Advanced" {
 		// Set the default network ID
-		p.SetNetworkids([]string{d.Get("network_id").(string)})
+		networkID := d.Get("network_id").(string)
+		p.SetNetworkids([]string{networkID})
+
+		// If no project is explicitly set, try to inherit it from the network
+		if _, ok := d.GetOk("project"); !ok && networkID != "" {
+			// Get the network to retrieve its project
+			// Use projectid=-1 to search across all projects
+			network, count, err := cs.Network.GetNetworkByID(networkID, cloudstack.WithProject("-1"))
+			if err == nil && count > 0 && network.Projectid != "" {
+				log.Printf("[DEBUG] Inheriting project %s from network %s", network.Projectid, networkID)
+				p.SetProjectid(network.Projectid)
+			}
+		}
 	}
 
 	// If there is a ipaddres supplied, add it to the parameter struct
@@ -414,6 +426,7 @@ func resourceCloudStackInstanceCreate(d *schema.ResourceData, meta interface{})
 	}
 
 	// If there is a project supplied, we retrieve and set the project id
+	// This will override the inherited project from network if explicitly set
 	if err := setProjectid(p, cs, d); err != nil {
 		return err
 	}
@@ -497,10 +510,22 @@ func resourceCloudStackInstanceRead(d *schema.ResourceData, meta interface{}) er
 	cs := meta.(*cloudstack.CloudStackClient)
 
 	// Get the virtual machine details
+	// First try with the project from state (if any)
+	project := d.Get("project").(string)
 	vm, count, err := cs.VirtualMachine.GetVirtualMachineByID(
 		d.Id(),
-		cloudstack.WithProject(d.Get("project").(string)),
+		cloudstack.WithProject(project),
 	)
+
+	// If not found and no explicit project was set, try with projectid=-1
+	// This handles the case where the project was inherited from network
+	if count == 0 && project == "" {
+		vm, count, err = cs.VirtualMachine.GetVirtualMachineByID(
+			d.Id(),
+			cloudstack.WithProject("-1"),
+		)
+	}
+
 	if err != nil {
 		if count == 0 {
 			log.Printf("[DEBUG] Instance %s does no longer exist", d.Get("name").(string))
@@ -516,6 +541,11 @@ func resourceCloudStackInstanceRead(d *schema.ResourceData, meta interface{}) er
 	d.Set("display_name", vm.Displayname)
 	d.Set("group", vm.Group)
 
+	// Set the project if the instance belongs to one
+	if vm.Project != "" {
+		d.Set("project", vm.Project)
+	}
+
 	// In some rare cases (when destroying a machine fails) it can happen that
 	// an instance does not have any attached NIC anymore.
 	if len(vm.Nic) > 0 {

cloudstack/resource_cloudstack_instance_test.go

@@ -234,6 +234,29 @@ func TestAccCloudStackInstance_project(t *testing.T) {
 	})
 }
 
+func TestAccCloudStackInstance_networkProjectInheritance(t *testing.T) {
+	var instance cloudstack.VirtualMachine
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckCloudStackInstanceDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCloudStackInstance_networkProjectInheritance,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckCloudStackInstanceExists(
+						"cloudstack_instance.foobar", &instance),
+					// Verify the project was inherited from the network
+					resource.TestCheckResourceAttr(
+						"cloudstack_instance.foobar", "project", "terraform"),
+					testAccCheckCloudStackInstanceProjectInherited(&instance),
+				),
+			},
+		},
+	})
+}
+
 func TestAccCloudStackInstance_import(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -371,6 +394,18 @@ func testAccCheckCloudStackInstanceRenamedAndResized(
 	}
 }
 
+func testAccCheckCloudStackInstanceProjectInherited(
+	instance *cloudstack.VirtualMachine) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+
+		if instance.Project != "terraform" {
+			return fmt.Errorf("Expected project to be 'terraform' (inherited from network), got: %s", instance.Project)
+		}
+
+		return nil
+	}
+}
+
 func testAccCheckCloudStackInstanceDestroy(s *terraform.State) error {
 	cs := testAccProvider.Meta().(*cloudstack.CloudStackClient)
 
@@ -576,3 +611,24 @@ ${random_bytes.string.base64}
 EOF
 EOFTF
 }`
+
+const testAccCloudStackInstance_networkProjectInheritance = `
+resource "cloudstack_network" "foo" {
+  name = "terraform-network"
+  display_text = "terraform-network"
+  cidr = "10.1.1.0/24"
+  network_offering = "DefaultIsolatedNetworkOfferingWithSourceNatService"
+  project = "terraform"
+  zone = "Sandbox-simulator"
+}
+
+resource "cloudstack_instance" "foobar" {
+  name = "terraform-test"
+  display_name = "terraform-test"
+  service_offering= "Small Instance"
+  network_id = cloudstack_network.foo.id
+  template = "CentOS 5.6 (64-bit) no GUI (Simulator)"
+  zone = cloudstack_network.foo.zone
+  expunge = true
+  # Note: project is NOT specified here - it should be inherited from the network
+}`

website/docs/r/instance.html.markdown

@@ -105,6 +105,29 @@ resource "cloudstack_instance" "from_template" {
 }
 ```
 
+### Instance with Automatic Project Inheritance
+
+```hcl
+# Create a network in a project
+resource "cloudstack_network" "project_network" {
+  name             = "project-network"
+  cidr             = "10.1.1.0/24"
+  network_offering = "DefaultIsolatedNetworkOfferingWithSourceNatService"
+  project          = "my-project"
+  zone             = "zone-1"
+}
+
+# Instance automatically inherits project from network
+resource "cloudstack_instance" "app" {
+  name             = "app-server"
+  service_offering = "small"
+  network_id       = cloudstack_network.project_network.id
+  template         = "CentOS 7"
+  zone             = cloudstack_network.project_network.zone
+  # project is automatically inherited from the network
+}
+```
+
 ## Argument Reference
 
 The following arguments are supported:
@@ -164,7 +187,9 @@ The following arguments are supported:
     this instance. Changing this forces a new resource to be created.
 
 * `project` - (Optional) The name or ID of the project to deploy this
-    instance to. Changing this forces a new resource to be created.
+    instance to. Changing this forces a new resource to be created. If not
+    specified and `network_id` is provided, the project will be automatically
+    inherited from the network.
 
 * `zone` - (Required) The name or ID of the zone where this instance will be
     created. Changing this forces a new resource to be created.