Move version check into PreCheck to fix unit tests

Moved the getCloudStackVersion() call from the test function body into the PreCheck
function. This ensures the version check only runs during acceptance tests (when TF_ACC
is set), not during unit tests. Previously, the version check would fail unit tests
when CloudStack environment variables were not set.

This follows the standard pattern where all environment-dependent setup happens in
PreCheck functions, which are only called by the test framework during acceptance tests.

Author: bhouse-nexthop

cloudstack/resource_cloudstack_loadbalancer_rule_test.go

@@ -54,18 +54,19 @@ func TestAccCloudStackLoadBalancerRule_basic(t *testing.T) {
 }
 
 func TestAccCloudStackLoadBalancerRule_update(t *testing.T) {
-	// Skip this test on CloudStack 4.22.0.0 due to a known simulator bug
-	// that causes "530 Internal Server Error" when updating load balancer rules.
-	// This bug does not exist in 4.20.1.0, 4.22.1.0+, or 4.23.0.0+.
-	version := getCloudStackVersion(t)
-	if version == "4.22.0.0" {
-		t.Skip("Skipping TestAccCloudStackLoadBalancerRule_update on CloudStack 4.22.0.0 due to known simulator bug (Error 530: Internal Server Error)")
-	}
-
 	var id string
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
+		PreCheck: func() {
+			testAccPreCheck(t)
+			// Skip this test on CloudStack 4.22.0.0 due to a known simulator bug
+			// that causes "530 Internal Server Error" when updating load balancer rules.
+			// This bug does not exist in 4.20.1.0, 4.22.1.0+, or 4.23.0.0+.
+			version := getCloudStackVersion(t)
+			if version == "4.22.0.0" {
+				t.Skip("Skipping TestAccCloudStackLoadBalancerRule_update on CloudStack 4.22.0.0 due to known simulator bug (Error 530: Internal Server Error)")
+			}
+		},
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudStackLoadBalancerRuleDestroy,
 		Steps: []resource.TestStep{