copilot suggestions

Author: bhouse-nexthop

cloudstack/provider_test.go

@@ -148,6 +148,8 @@ func testAccPreCheck(t *testing.T) {
 
 // getCloudStackVersion returns the CloudStack version from the API
 func getCloudStackVersion(t *testing.T) string {
+	t.Helper()
+
 	cfg := Config{
 		APIURL:      os.Getenv("CLOUDSTACK_API_URL"),
 		APIKey:      os.Getenv("CLOUDSTACK_API_KEY"),
@@ -157,15 +159,13 @@ func getCloudStackVersion(t *testing.T) string {
 	}
 	cs, err := cfg.NewClient()
 	if err != nil {
-		t.Logf("Failed to create CloudStack client: %v", err)
-		return ""
+		t.Fatalf("Failed to create CloudStack client: %v", err)
 	}
 
 	p := cs.Configuration.NewListCapabilitiesParams()
 	r, err := cs.Configuration.ListCapabilities(p)
 	if err != nil {
-		t.Logf("Failed to get CloudStack capabilities: %v", err)
-		return ""
+		t.Fatalf("Failed to get CloudStack capabilities: %v", err)
 	}
 
 	if r.Capabilities != nil {

cloudstack/resource_cloudstack_loadbalancer_rule_test.go

@@ -57,7 +57,6 @@ func TestAccCloudStackLoadBalancerRule_update(t *testing.T) {
 	// Skip this test on CloudStack 4.22.0.0 due to a known simulator bug
 	// that causes "530 Internal Server Error" when updating load balancer rules.
 	// This bug does not exist in 4.20.1.0, 4.22.1.0+, or 4.23.0.0+.
-	// See: https://github.com/apache/cloudstack/issues/XXXXX (if applicable)
 	testAccPreCheck(t)
 	version := getCloudStackVersion(t)
 	if version == "4.22.0.0" {