Fix userdata details being improperly serialized

Author: bddvlpr

cloudstack/resource_cloudstack_instance.go

@@ -462,13 +462,11 @@ func resourceCloudStackInstanceCreate(d *schema.ResourceData, meta interface{})
 	}
 
 	if userdataDetails, ok := d.GetOk("userdata_details"); ok {
-		udDetails := make(map[string]string)
-		index := 0
+		ud := make(map[string]string)
 		for k, v := range userdataDetails.(map[string]interface{}) {
-			udDetails[fmt.Sprintf("userdatadetails[%d].%s", index, k)] = v.(string)
-			index++
+			ud[k] = v.(string)
 		}
-		p.SetUserdatadetails(udDetails)
+		p.SetUserdatadetails(ud)
 	}
 
 	// Create the new instance
@@ -825,13 +823,11 @@ func resourceCloudStackInstanceUpdate(d *schema.ResourceData, meta interface{})
 
 			p := cs.VirtualMachine.NewUpdateVirtualMachineParams(d.Id())
 			if userdataDetails, ok := d.GetOk("userdata_details"); ok {
-				udDetails := make(map[string]string)
-				index := 0
+				ud := make(map[string]string)
 				for k, v := range userdataDetails.(map[string]interface{}) {
-					udDetails[fmt.Sprintf("userdatadetails[%d].%s", index, k)] = v.(string)
-					index++
+					ud[k] = v.(string)
 				}
-				p.SetUserdatadetails(udDetails)
+				p.SetUserdatadetails(ud)
 			}
 			_, err := cs.VirtualMachine.UpdateVirtualMachine(p)
 			if err != nil {

go.mod

@@ -18,7 +18,7 @@
 module github.com/terraform-providers/terraform-provider-cloudstack
 
 require (
-	github.com/apache/cloudstack-go/v2 v2.18.1
+	github.com/apache/cloudstack-go/v2 v2.19.0
 	github.com/go-ini/ini v1.67.0
 	github.com/hashicorp/go-multierror v1.1.1
 	github.com/hashicorp/terraform-plugin-framework v1.12.0

go.sum

@@ -6,8 +6,8 @@ github.com/ProtonMail/go-crypto v1.1.0-alpha.0 h1:nHGfwXmFvJrSR9xu8qL7BkO4DqTHXE
 github.com/ProtonMail/go-crypto v1.1.0-alpha.0/go.mod h1:rA3QumHc/FZ8pAHreoekgiAbzpNsfQAosU5td4SnOrE=
 github.com/agext/levenshtein v1.2.2 h1:0S/Yg6LYmFJ5stwQeRp6EeOcCbj7xiqQSdNelsXvaqE=
 github.com/agext/levenshtein v1.2.2/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki2W0IB5558=
-github.com/apache/cloudstack-go/v2 v2.18.1 h1:SgdRUEj5x17wSPfwAacjWgTqbtS/u7iaqnbpILWzE1c=
-github.com/apache/cloudstack-go/v2 v2.18.1/go.mod h1:p/YBUwIEkQN6CQxFhw8Ff0wzf1MY0qRRRuGYNbcb1F8=
+github.com/apache/cloudstack-go/v2 v2.19.0 h1:YHLw770MmgiqXx6NRFYw2Nr7DpnylLhLG2KYNCftgnc=
+github.com/apache/cloudstack-go/v2 v2.19.0/go.mod h1:p/YBUwIEkQN6CQxFhw8Ff0wzf1MY0qRRRuGYNbcb1F8=
 github.com/apparentlymart/go-textseg/v12 v12.0.0/go.mod h1:S/4uRK2UtaQttw1GenVJEynmyUenKwP++x/+DdGV/Ec=
 github.com/apparentlymart/go-textseg/v15 v15.0.0 h1:uYvfpb3DyLSCGWnctWKGj857c6ew1u1fNQOlOtuGxQY=
 github.com/apparentlymart/go-textseg/v15 v15.0.0/go.mod h1:K8XmNZdhEBkdlyDdvbmmsvpAG721bKi0joRfFdHIWJ4=