Skip to content

Fix creation of firewall & Egress firewall rules when created in a project #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 1 commit into from
Jul 23, 2025
Merged

Fix creation of firewall & Egress firewall rules when created in a project #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cloudstack/resource_cloudstack_egress_firewall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ func resourceCloudStackEgressFirewall() *schema.Resource {
ForceNew: true,
},

"project": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ForceNew: true,
},

"managed": {
Type: schema.TypeBool,
Optional: true,
Expand Down Expand Up @@ -265,6 +272,11 @@ func resourceCloudStackEgressFirewallRead(d *schema.ResourceData, meta interface
p.SetNetworkid(d.Id())
p.SetListall(true)

// If there is a project supplied, we retrieve and set the project id
if err := setProjectid(p, cs, d); err != nil {
return err
}

l, err := cs.Firewall.ListEgressFirewallRules(p)
if err != nil {
return err
Expand Down
12 changes: 12 additions & 0 deletions cloudstack/resource_cloudstack_firewall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ func resourceCloudStackFirewall() *schema.Resource {
ForceNew: true,
},

"project": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ForceNew: true,
},

"managed": {
Type: schema.TypeBool,
Optional: true,
Expand Down Expand Up @@ -256,6 +263,11 @@ func resourceCloudStackFirewallRead(d *schema.ResourceData, meta interface{}) er
p.SetIpaddressid(d.Id())
p.SetListall(true)

// If there is a project supplied, we retrieve and set the project id
if err := setProjectid(p, cs, d); err != nil {
return err
}

l, err := cs.Firewall.ListFirewallRules(p)
if err != nil {
return err
Expand Down
Loading