Fix UserData not being found when added to a project

[bddvlpr]

Description

When a user data resource is nested in a particular project using project_id, a global search will not find that particular user data.

If for some reason (as the case before),the userdata list command succeeds but doesn't contain any user data itself, throw an error for that.

Reproduce bug

resource "cloudstack_project" "test-project" {
  name = "test-project"
}

resource "cloudstack_user_data" "test-userdata" {
  name = "cloudinit-test"
  userdata = base64encode(file("../some-cloudinit.yaml"))
  project_id = cloudstack_project.test-project.id
}

[Copilot]

Pull request overview

This PR fixes cloudstack_user_data read behavior when the user data is registered under a CloudStack project by ensuring the read lookup includes project_id, preventing “not found” results from global-only searches.

Changes:

• Include project_id in ListUserData parameters during resource read.
• Add a guard for empty ListUserData results to avoid indexing into an empty slice.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

cloudstack/resource_cloudstack_user_data.go:142

• PR description says that if ListUserData succeeds but returns no entries, the provider should throw an error. This new branch instead logs and clears the resource ID (treating it as deleted), which changes behavior and can cause Terraform to silently “forget” an existing user data if the API returns an empty list unexpectedly. Please either update the PR description to match the intended ‘treat as deleted’ behavior, or change this branch to return an explicit error when zero results are returned.

	if len(userdata.UserData) == 0 {
		log.Printf("[DEBUG] User data %s no longer exists", id)
		d.SetId("")
		return nil
	}