Allow 'all' on security group rule protocol

[bddvlpr]

Allows setting "all" as the protocol for security group rules.

Closes #274.

[Copilot]

Pull request overview

Adds support for using protocol = "all" in cloudstack_security_group_rule, aligning provider validation/behavior with the documented allowed values and closing #274.

Changes:

• Create security group rules when protocol is set to "all".
• Read back "all" protocol rules into state.
• Extend acceptance test configs/assertions to include "all" protocol rules.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
cloudstack/resource_cloudstack_security_group_rule.go	Adds create/read/validation handling for protocol = "all" on security group rules.
cloudstack/resource_cloudstack_security_group_rule_test.go	Updates acceptance tests to exercise the new "all" protocol behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

cloudstack/resource_cloudstack_security_group_rule.go:651

• protocol = "all" currently skips validation, but the provider will ignore ports (and ICMP fields) when creating rules. That allows configurations that appear to constrain ports/ICMP but won’t be enforced by CloudStack, and can leave Terraform state misleading. Reject incompatible fields when protocol is all.

	protocol := rule["protocol"].(string)
	switch protocol {
	case "all":
		break
	case "icmp":