Rahulbcn27 GitHub actions 1#49
Merged
Merged
Conversation
Contributor
Author
|
@rohityadavcloud Please review. |
yadvr
reviewed
Jan 30, 2023
| @@ -0,0 +1,26 @@ | |||
| name: Build-Check | |||
Member
yadvr
reviewed
Jan 30, 2023
| - name: Set up Go | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.16.x |
Member
There was a problem hiding this comment.
Should we bump the version to latest?
Contributor
Author
There was a problem hiding this comment.
version updated to 1.19.x
yadvr
approved these changes
Jan 30, 2023
Member
|
For basic build and unit tests this is good. However, we need to explore if some basic CI/CD using https://github.com/apache/cloudstack-terraform-provider#testing-the-provider (simulator) can be achieved as well. I'll merge this but explore further with @rahulbcn27 about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created Github-Actions build.yml