Skip to content

Rahulbcn27 GitHub actions 1#49

Merged
yadvr merged 9 commits into
apache:mainfrom
rahulbcn27:rahulbcn27-github-actions-1
Jan 30, 2023
Merged

Rahulbcn27 GitHub actions 1#49
yadvr merged 9 commits into
apache:mainfrom
rahulbcn27:rahulbcn27-github-actions-1

Conversation

@rahulbcn27

Copy link
Copy Markdown
Contributor

Created Github-Actions build.yml

@rahulbcn27

Copy link
Copy Markdown
Contributor Author

@rohityadavcloud Please review.

@@ -0,0 +1,26 @@
name: Build-Check

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulbcn27 pl add license

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license added

@yadvr

yadvr commented Jan 30, 2023

Copy link
Copy Markdown
Member

Comment thread .github/workflows/build.yml Outdated
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.16.x

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump the version to latest?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version updated to 1.19.x

@yadvr

yadvr commented Jan 30, 2023

Copy link
Copy Markdown
Member

For basic build and unit tests this is good. However, we need to explore if some basic CI/CD using https://github.com/apache/cloudstack-terraform-provider#testing-the-provider (simulator) can be achieved as well. I'll merge this but explore further with @rahulbcn27 about this.

@yadvr yadvr merged commit 61f86a9 into apache:main Jan 30, 2023
@harikrishna-patnala harikrishna-patnala added this to the v0.5.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants