Add source_nat_ip_address attribute to cloudstack_network resource#51
Merged
Conversation
|
@harikrishna-patnala @rohityadavcloud can we have this reviewed and merged? |
yadvr
reviewed
Mar 28, 2023
yadvr
left a comment
yadvr
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I don’t know the code very well. Perhaps @harikrishna-patnala you can do some quick check and review?
poddm
pushed a commit
to poddm/cloudstack-terraform-provider
that referenced
this pull request
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the attribute
source_nat_ip_addressto thecloudstack_networkresource, which can be passed to provisioner connection blocks (host parameter).This PR fixes #16 and will save a lot of wasted IP addresses :)