Improves service offering resource#64
Merged
vishesh92 merged 11 commits intoMar 6, 2024
Merged
Conversation
yadvr
reviewed
Aug 4, 2023
yadvr
reviewed
Aug 4, 2023
yadvr
approved these changes
Aug 4, 2023
yadvr
left a comment
yadvr
left a comment
Member
There was a problem hiding this comment.
LGTM didn't test it though; let's see how the github actions behave
Member
|
@fabiomatavelli thank you for the PR. I liked how you've introduce a CI github action. There is a conflict with README, could you help resolve it. |
Collaborator
Author
|
changes applied @rohityadavcloud, I think you'll need to approve it again |
Member
|
Thanks @fabiomatavelli re-running github actions |
Merged
Member
|
@fabiomatavelli can you help review/resolve the conflict? |
Collaborator
Author
|
done @rohityadavcloud |
vishesh92
reviewed
Mar 4, 2024
vishesh92
reviewed
Mar 6, 2024
Co-authored-by: Vishesh <vishesh92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here is some improvement in the
cloudstack_service_offeringresource so we can specify thecpu_number,cpu_speedandmemorynow.I've added the acceptance test CI which can be run with different versions of Cloudstack. Although it is failing, the specific test for this change is passing:
Also, I made a change in the README to include the updated version of the
cloudstack-simulator.