Add UEFI support#83
Merged
Merged
Conversation
a03e140 to
b0ecaf9
Compare
|
@vdombrovski whaouuuuuu : awesome, thanks for this; it's very usefull. |
yadvr
reviewed
Feb 19, 2024
kiranchavala
approved these changes
Mar 6, 2024
kiranchavala
left a comment
Member
There was a problem hiding this comment.
LGTM
Created UEFI enabled host and registered a UEFI template
Deployed a vm from terraform succefully
resource "cloudstack_instance" "test-vm" {
name = var.instance_name
service_offering = var.instance_service_offering
network_id = cloudstack_network.test-network.id
template = var.instance_template
zone = var.zone
uefi = true
expunge = true
depends_on = [
cloudstack_network.test-network
]
}
# cloudstack_instance.test-vm will be created
+ resource "cloudstack_instance" "test-vm" {
+ display_name = (known after apply)
+ expunge = true
+ group = (known after apply)
+ id = (known after apply)
+ ip_address = (known after apply)
+ name = "hyd-demo-test"
+ network_id = (known after apply)
+ project = (known after apply)
+ root_disk_size = (known after apply)
+ service_offering = "17dfb0b2-a153-4aae-aa79-41d830cf061b"
+ start_vm = true
+ tags = (known after apply)
+ template = "ce2c6626-9dc9-4f3e-abea-a34bc6ee009f"
+ uefi = true
+ zone = "3e99a7d7-f23c-4650-8fc4-f5ebb9ea06c9"
}
cloudstack_instance.test-vm: Still creating... [30s elapsed]
cloudstack_instance.test-vm: Still creating... [40s elapsed]
cloudstack_instance.test-vm: Creation complete after 49s [id=eccbfa4b-f932-4489-af08-78aee336aabd]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds a new boolean parameter to the cloudstack_instance resource, called "uefi". When set, the instance will boot in UEFI/Legacy mode.