Address copilot's review

Author: erikbocks

api/src/main/java/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java

@@ -56,7 +56,7 @@ public class AddIpToVmNicCmd extends BaseAsyncCreateCmd {
     @Parameter(name = ApiConstants.IP_ADDRESS, type = CommandType.STRING, required = false, description = "Secondary IP Address")
     private String ipAddr;
 
-    @Parameter(name = ApiConstants.DESCRIPTION, type = CommandType.STRING, required = false, description = "Description")
+    @Parameter(name = ApiConstants.DESCRIPTION, type = CommandType.STRING, required = false, description = "Description", length = 2048)
     private String description;
 
     /////////////////////////////////////////////////////

server/src/main/java/com/cloud/network/rules/RulesManagerImpl.java

@@ -467,7 +467,7 @@ private boolean enableStaticNat(long ipId, long vmId, long networkId, boolean is
         boolean isOneToOneNat = ipAddress.isOneToOneNat();
         Long associatedWithVmId = ipAddress.getAssociatedWithVmId();
         Nic guestNic;
-        wNicSecondaryIpVO nicSecIp = null;
+        NicSecondaryIpVO nicSecIp = null;
         String dstIp = null;
         Network network = _networkModel.getNetwork(networkId);
 

ui/src/views/network/NicsTab.vue

@@ -218,8 +218,7 @@
           <p class="modal-form__label">{{ $t('label.secondaryip.description') }}</p>
           <a-input
             :placeholder="$t('label.new.secondaryip.description.description')"
-            v-model:value="newSecondaryIpDescription"
-            v-focus="editNicResource.type!=='Shared'"></a-input>
+            v-model:value="newSecondaryIpDescription"></a-input>
         </div>
 
         <div style="margin-top: 10px; display: flex; justify-content:flex-end;">

ui/src/views/network/NicsTable.vue

@@ -39,7 +39,7 @@
           {{ record.traffictype }}
         </a-descriptions-item>
         <a-descriptions-item :label="$t('label.secondaryips')" v-if="record.secondaryip && record.secondaryip.length > 0 && record.type !== 'L2'">
-          {{ record.secondaryip.map(x => x.ipaddress + ': ' + x.description ).join(', ') }}
+          {{ record.secondaryip.map(x => x.description ? (x.ipaddress + ': ' + x.description) : x.ipaddress).join(', ') }}
         </a-descriptions-item>
         <a-descriptions-item :label="$t('label.ip6address')" v-if="record.ip6address">
           {{ record.ip6address }}