Skip to content

Commit 0993585

Browse files
committed
Addressed comments
1 parent 4028c0b commit 0993585

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

test/integration/plugins/storpool/test_snapshot_copy_on_primary_storage.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ def test_01_take_snapshot_multi_zone(self):
162162
"""
163163

164164
snapshot = Snapshot.create(self.userapiclient, volume_id=self.volume.id, zoneids=[str(self.additional_zone.id)], usestoragereplication=True)
165+
# the snapshot has to be deleted when the class cleanup is done. Otherwise use Time.sleep(420) ans self.cleanup to clean it after each test. This will increase the tests execution
165166
self._cleanup.append(snapshot)
166167
self.snapshot_id = snapshot.id
167168
self.helper.verify_snapshot_copies(self.userapiclient, self.snapshot_id, [self.zone.id, self.additional_zone.id])
@@ -174,6 +175,7 @@ def test_02_copy_snapshot_multi_pools(self):
174175
"""
175176

176177
snapshot = Snapshot.create(self.userapiclient, volume_id=self.volume.id)
178+
# the snapshot has to be deleted when the class cleanup is done. Otherwise use Time.sleep(420) ans self.cleanup to clean it after each test. This will increase the tests execution
177179
self._cleanup.append(snapshot)
178180
self.snapshot_id = snapshot.id
179181
Snapshot.copy(self.userapiclient, self.snapshot_id, zone_ids=[str(self.additional_zone.id)], source_zone_id=self.zone.id, usestoragereplication=True)
@@ -220,6 +222,7 @@ def test_05_take_snapshot_multi_zone_create_volume_additional_zone(self):
220222
"""
221223

222224
snapshot = Snapshot.create(self.userapiclient,volume_id=self.volume.id, zoneids=[str(self.additional_zone.id)], usestoragereplication=True)
225+
# the snapshot has to be deleted when the class cleanup is done. Otherwise use Time.sleep(420) ans self.cleanup to clean it after each test. This will increase the tests execution
223226
self._cleanup.append(snapshot)
224227
self.snapshot_id = snapshot.id
225228
self.helper.verify_snapshot_copies(self.userapiclient, self.snapshot_id, [self.zone.id, self.additional_zone.id])
@@ -246,6 +249,7 @@ def test_06_take_snapshot_multi_zone_create_template_additional_zone(self):
246249
"""Test to take volume snapshot in multiple StorPool primary storages in diff zones and create a volume in one of the additional zones
247250
"""
248251
snapshot = Snapshot.create(self.userapiclient, volume_id=self.volume.id, zoneids=[str(self.additional_zone.id)], usestoragereplication=True)
252+
# the snapshot has to be deleted when the class cleanup is done. Otherwise use Time.sleep(420) ans self.cleanup to clean it after each test. This will increase the tests execution
249253
self._cleanup.append(snapshot)
250254
self.snapshot_id = snapshot.id
251255
self.helper.verify_snapshot_copies(self.userapiclient, self.snapshot_id, [self.zone.id, self.additional_zone.id])
@@ -261,6 +265,7 @@ def test_07_take_snapshot_multi_zone_deploy_vm_additional_zone(self):
261265
"""Test to take volume snapshot in multiple StorPool primary storages in diff zones and deploy a VM from snapshot in one of the additional zones
262266
"""
263267
snapshot = Snapshot.create(self.userapiclient, volume_id=self.volume.id, zoneids=[str(self.additional_zone.id)], usestoragereplication=True)
268+
# the snapshot has to be deleted when the class cleanup is done. Otherwise use Time.sleep(420) ans self.cleanup to clean it after each test. This will increase the tests execution
264269
self._cleanup.append(snapshot)
265270
self.snapshot_id = snapshot.id
266271
self.helper.verify_snapshot_copies(self.userapiclient, self.snapshot_id, [self.zone.id, self.additional_zone.id])

0 commit comments

Comments
 (0)