Skip to content

Commit 121a35d

Browse files
authored
linstor: do not use the same static ApiClient for all calls (#9326)
The client.setBasePath() would overwrite the Linstor controller IP/host for all current client users. This is basically a race condition that triggered as soon as you had configured 2 different primary storages with different Linstor controllers.
1 parent 983f164 commit 121a35d

File tree

1 file changed

+1
-2
lines changed
  • plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util

1 file changed

+1
-2
lines changed

plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util/LinstorUtil.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.linbit.linstor.api.ApiClient;
2020
import com.linbit.linstor.api.ApiException;
21-
import com.linbit.linstor.api.Configuration;
2221
import com.linbit.linstor.api.DevelopersApi;
2322
import com.linbit.linstor.api.model.ApiCallRc;
2423
import com.linbit.linstor.api.model.ApiCallRcList;
@@ -46,7 +45,7 @@ public class LinstorUtil {
4645
public static final String CLUSTER_DEFAULT_MAX_IOPS = "clusterDefaultMaxIops";
4746

4847
public static DevelopersApi getLinstorAPI(String linstorUrl) {
49-
ApiClient client = Configuration.getDefaultApiClient();
48+
ApiClient client = new ApiClient();
5049
client.setBasePath(linstorUrl);
5150
return new DevelopersApi(client);
5251
}

0 commit comments

Comments
 (0)