Handle login page provider visibility

Author: Damans227

plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/ListOAuthProvidersCmd.java

@@ -127,9 +127,10 @@ public String authenticate(String command, Map<String, Object[]> params, HttpSes
         }
 
         List<OauthProviderVO> resultList = _oauth2mgr.listOauthProviders(provider, id, domainId);
+        boolean isAuthenticated = session != null && session.getAttribute(ApiConstants.USER_ID) != null;
         if (domainRequested && domainId != null && domainId > 0) {
             resultList.removeIf(p -> p.getDomainId() == null);
-        } else if (!domainRequested) {
+        } else if (!domainRequested && !isAuthenticated) {
             resultList.removeIf(p -> p.getDomainId() != null);
         }
 
@@ -153,8 +154,20 @@ public String authenticate(String command, Map<String, Object[]> params, HttpSes
             responses.add(r);
         }
 
+        int totalEnabledCount = responses.size();
+        if (!domainRequested && !isAuthenticated) {
+            List<OauthProviderVO> allProviders = _oauth2mgr.listOauthProviders(null, null, null);
+            for (OauthProviderVO domainProvider : allProviders) {
+                if (domainProvider.getDomainId() != null && domainProvider.isEnabled()
+                        && Boolean.TRUE.equals(OAuth2AuthManager.OAuth2IsPluginEnabled.valueInScope(ConfigKey.Scope.Domain, domainProvider.getDomainId(), true))
+                        && authenticatorPluginNames.contains(domainProvider.getProvider())) {
+                    totalEnabledCount++;
+                }
+            }
+        }
+
         ListResponse<OauthProviderResponse> response = new ListResponse<>();
-        response.setResponses(responses, resultList.size());
+        response.setResponses(responses, totalEnabledCount);
         response.setResponseName(getCommandName());
         setResponseObject(response);
 

ui/src/views/auth/Login.vue

@@ -203,6 +203,7 @@
         </div>
         <div v-else style="text-align: center; color: #999; padding: 20px 0;">
           <span v-if="form.oauthDomain">No OAuth providers configured for this domain</span>
+          <span v-else>Enter your domain to see available providers</span>
         </div>
       </a-tab-pane>
     </a-tabs>
@@ -380,7 +381,8 @@ export default {
                 this.githubredirecturi = item.redirecturi
               }
             })
-            this.socialLogin = oauthproviders.some(item => item.enabled)
+            const totalCount = response.listoauthproviderresponse.count || 0
+            this.socialLogin = totalCount > 0
             this.oauthGithubProvider = this.githubprovider
             this.oauthGoogleProvider = this.googleprovider
             this.oauthGithubClientId = this.githubclientid