adaptive: honor user-provided capacityBytes when provider stats are unavailable

AdaptiveDataStoreLifeCycleImpl.initialize() guarded the user-provided
capacityBytes behind stats != null when computing the pool capacity to
persist. As a consequence, any adaptive provider that could not report
capacity yet (for example a FlashArray pod that has not been given a
quota and has no footprint yet, or a transient probe failure) caused the
whole pool registration to fail with "Capacity bytes not available from
the storage provider, user provided capacity bytes must be specified"
even when the operator had passed capacityBytes= on createStoragePool.

Accept the user-supplied value unconditionally and use the provider
stats only as an upper-bound sanity check when they are actually
available. The "no user-provided capacity, no provider capacity" branch
is preserved and still raises the same InvalidParameterValueException.

Signed-off-by: Eugenio Grosso <eugenio.grosso@gmail.com>

Author: genegr

plugins/storage/volume/adaptive/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/AdaptiveDataStoreLifeCycleImpl.java

@@ -217,13 +217,14 @@ public DataStore initialize(Map<String, Object> dsInfos) {
             // validate the provided details are correct/valid for the provider
             api.validate();
 
-            // if we have user-provided capacity bytes, validate they do not exceed the manaaged storage capacity bytes
+            // User-provided capacityBytes always wins; validate against storage stats only when
+            // the provider could actually report them. If the provider cannot (empty pod with no
+            // footprint, no quota set, transient probe failure), fall through and use what the
+            // user supplied rather than failing the whole registration.
             ProviderVolumeStorageStats stats = api.getManagedStorageStats();
-            if (capacityBytes != null && capacityBytes != 0 && stats != null) {
-                if (stats.getCapacityInBytes() > 0) {
-                    if (stats.getCapacityInBytes() < capacityBytes) {
-                        throw new InvalidParameterValueException("Capacity bytes provided exceeds the capacity of the storage endpoint: provided by user: " + capacityBytes + ", storage capacity from storage provider: " + stats.getCapacityInBytes());
-                    }
+            if (capacityBytes != null && capacityBytes != 0) {
+                if (stats != null && stats.getCapacityInBytes() > 0 && stats.getCapacityInBytes() < capacityBytes) {
+                    throw new InvalidParameterValueException("Capacity bytes provided exceeds the capacity of the storage endpoint: provided by user: " + capacityBytes + ", storage capacity from storage provider: " + stats.getCapacityInBytes());
                 }
                 parameters.setCapacityBytes(capacityBytes);
             }