api: fix new password is applied on host when update host password with update_passwd_on_host=false (#7092)

Author: weizhouapache

api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java

@@ -23,6 +23,7 @@
 import org.apache.cloudstack.api.response.ClusterResponse;
 import org.apache.cloudstack.api.response.HostResponse;
 import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.commons.lang3.BooleanUtils;
 import org.apache.log4j.Logger;
 
 import com.cloud.user.Account;
@@ -67,7 +68,7 @@ public Long getClusterId() {
     }
 
     public Boolean getUpdatePasswdOnHost() {
-        return updatePasswdOnHost == null ? false : true;
+        return BooleanUtils.isTrue(updatePasswdOnHost);
     }
 
     public String getPassword() {

api/src/test/java/org/apache/cloudstack/api/command/test/UpdateHostPasswordCmdTest.java

@@ -27,6 +27,7 @@
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.Mockito;
+import org.springframework.test.util.ReflectionTestUtils;
 
 import com.cloud.exception.InvalidParameterValueException;
 import com.cloud.resource.ResourceService;
@@ -94,4 +95,15 @@ public void testCreateSuccess() {
         assertFalse("The attribute updatePasswdOnHost should be false, but it isn't.", updateHostPasswordCmd.getUpdatePasswdOnHost());
         verify(managementServer, times(1)).updateHostPassword(updateHostPasswordCmd);
     }
-}
+
+    @Test
+    public void testGetUpdatePasswdOnHostValues() {
+        assertFalse(updateHostPasswordCmd.getUpdatePasswdOnHost());
+
+        ReflectionTestUtils.setField(updateHostPasswordCmd, "updatePasswdOnHost", false);
+        assertFalse(updateHostPasswordCmd.getUpdatePasswdOnHost());
+
+        ReflectionTestUtils.setField(updateHostPasswordCmd, "updatePasswdOnHost", true);
+        assertTrue(updateHostPasswordCmd.getUpdatePasswdOnHost());
+    }
+}