Fix build

Author: nvazquez

api/src/main/java/org/apache/cloudstack/acl/APIChecker.java

@@ -25,13 +25,14 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 /**
  * APICheckers is designed to verify the ownership of resources and to control the access to APIs.
  */
 public interface APIChecker extends Adapter {
-    Logger s_logger = Logger.getLogger(APIChecker.class.getName());
+    Logger LOGGER = LogManager.getLogger(APIChecker.class);
     // Interface for checking access for a role using apiname
     // If true, apiChecker has checked the operation
     // If false, apiChecker is unable to handle the operation or not implemented
@@ -59,7 +60,7 @@ default List<String> getApisAllowedToAccount(Account account, List<String> apiNa
                 // Propagate as unchecked so callers are aware of the failure.
                 throw new RuntimeException("Failed to check access for API [" + apiName + "] due to request limits", e);
             } catch (PermissionDeniedException e) {
-                s_logger.trace("Account [" + account + "] is not allowed to access API [" + apiName + "]");
+                LOGGER.trace("Account [" + account + "] is not allowed to access API [" + apiName + "]");
             }
         }
         return allowedApis;

server/src/main/java/com/cloud/user/AccountManagerImpl.java

@@ -1459,11 +1459,17 @@ protected void checkRoleEscalation(Account caller, Account requested) {
             escalatedApis.removeAll(callerAllowed);
             String msg = String.format("User of Account %s and domain %s cannot create an account with access to more privileges than they have. Escalated APIs: %s",
                     caller, _domainMgr.getDomain(caller.getDomainId()), escalatedApis);
-            s_logger.warn(msg);
+            logger.warn(msg);
             throw new PermissionDeniedException(msg);
         }
     }
 
+    private void checkApiAccess(List<APIChecker> apiCheckers, Account caller, String command) {
+        for (final APIChecker apiChecker : apiCheckers) {
+            apiChecker.checkAccess(caller, command);
+        }
+    }
+
     @Override
     public void checkApiAccess(Account caller, String command) {
         List<APIChecker> apiCheckers = getEnabledApiCheckers();